Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cp/initial job form #230

Merged
merged 14 commits into from
Jul 14, 2023
Merged

Cp/initial job form #230

merged 14 commits into from
Jul 14, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Jul 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

UI is pretty important.

  • Initial commit for the libraries we will be using for the UI (Chakra UI, TailwindCSS, heroicon, react-selct, react-virtualize, formik, Apollo, ect...)
  • Created the basic PageLayout and SideBar for pages.
  • Created a form to take in basic Job data submit it with apollo.
  • Created a multi select autocomplete search bar that can be used to select sessions or session tags.

Improvements needed

  • Improve error handling / expand error handling
  • Restructure directories / files
  • Testing + Validation
  • Expand typing

Relevant Screenshots

Screenshot 2023-07-12 at 11 10 45 PM Screenshot 2023-07-12 at 11 11 55 PM Screenshot 2023-07-12 at 11 12 48 PM

Which issue(s) this PR fixes:

No UI :(

@cmp5987 cmp5987 added feature New feature or request tavern Frontend labels Jul 13, 2023
@cmp5987 cmp5987 requested a review from hulto July 13, 2023 03:13
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #230 (e5792e5) into main (5fa0273) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   72.29%   72.29%           
=======================================
  Files          82       82           
  Lines        4675     4675           
=======================================
  Hits         3380     3380           
  Misses       1210     1210           
  Partials       85       85           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto
Copy link
Collaborator

hulto commented Jul 13, 2023

image
LOL

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@cmp5987 cmp5987 merged commit dda8fcb into main Jul 14, 2023
8 checks passed
@cmp5987 cmp5987 deleted the cp/initial-job-form branch July 14, 2023 01:14
hulto pushed a commit that referenced this pull request Sep 30, 2023
* feat(job-form): Create initial form for job creation

* fix(job-form): Add filter handling to target selection

* fix(create-job): Add deletion and formik handling

* fix(apollo): Basic apollo install

* feat(create-job): Add tailwind, modify components

* fix(create-job): Continue to build out steps and add icon

* fix(select-session): Work on setting up session step

* fix(select-sessions): Add virtualize and memo for checkboxes

* fix(selected-only): Add selected only filter

* fix(context): Group query and move it to context

* fix(createJob): Add create job mutation

* fix(submit-job): Add submit job

* fix(package-lock): Remove package-lock.json
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Cp/initial job form (#230)

* feat(job-form): Create initial form for job creation

* fix(job-form): Add filter handling to target selection

* fix(create-job): Add deletion and formik handling

* fix(apollo): Basic apollo install

* feat(create-job): Add tailwind, modify components

* fix(create-job): Continue to build out steps and add icon

* fix(select-session): Work on setting up session step

* fix(select-sessions): Add virtualize and memo for checkboxes

* fix(selected-only): Add selected only filter

* fix(context): Group query and move it to context

* fix(createJob): Add create job mutation

* fix(submit-job): Add submit job

* fix(package-lock): Remove package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Frontend tavern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants