Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Added test data for a job with tasks in various states #236

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

KCarretto
Copy link
Collaborator

@KCarretto KCarretto commented Jul 15, 2023

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

Creates test data for a job that has tasks in various states.

image

Which issue(s) this PR fixes:

Fixes #233

@KCarretto KCarretto requested review from hulto and cmp5987 July 15, 2023 01:30
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #236 (5ffa578) into main (dda8fcb) will increase coverage by 1.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   72.29%   73.85%   +1.55%     
==========================================
  Files          82       82              
  Lines        4675     4750      +75     
==========================================
+ Hits         3380     3508     +128     
+ Misses       1210     1156      -54     
- Partials       85       86       +1     
Impacted Files Coverage Δ
tavern/test_data.go 98.46% <100.00%> (+98.46%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀🚀🚀

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@cmp5987 cmp5987 merged commit 324b363 into main Jul 17, 2023
8 checks passed
@cmp5987 cmp5987 deleted the test-data-job branch July 17, 2023 22:57
hulto pushed a commit that referenced this pull request Sep 30, 2023
* Added test data for a job with tasks in various states

* added test case for 'createTestData'
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
[feature] Added test data for a job with tasks in various states (#236)

* Added test data for a job with tasks in various states

* added test case for 'createTestData'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase verbosity of tavern test data.
3 participants