Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sys.get_os #238

Merged
merged 4 commits into from
Jul 22, 2023
Merged

Implement sys.get_os #238

merged 4 commits into from
Jul 22, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jul 17, 2023

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #237

@hulto hulto added feature New feature or request eldritch Related to the Eldritch language labels Jul 17, 2023
@hulto hulto linked an issue Jul 17, 2023 that may be closed by this pull request
Implement eldritch sys.get_os function to retrieve the os details about the current system. #237
Closed
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited

Codecov Report

Merging #238 (44441d1) into main (098afd7) will increase coverage by 0.15%.
The diff coverage is 92.68%.

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   74.09%   74.24%   +0.15%     
==========================================
  Files          83       84       +1     
  Lines        4806     4846      +40     
==========================================
+ Hits         3561     3598      +37     
- Misses       1159     1162       +3     
  Partials       86       86
Impacted Files Coverage Δ
implants/lib/eldritch/src/sys.rs 56.60% <50.00%> (-0.54%) ⬇️
implants/lib/eldritch/src/sys/get_os_impl.rs 97.22% <97.22%> (ø)
implants/lib/eldritch/src/lib.rs 92.22% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Cictrone
Cictrone approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

implants/lib/eldritch/src/sys/get_os_impl.rs Show resolved Hide resolved
@hulto
Merge branch 'main' into 237-implement-eldritch-sysget_os-function-to…
7b19668 
…-retrieve-the-os-details-about-the-current-system
@hulto
Merge branch 'main' into 237-implement-eldritch-sysget_os-function-to…
44441d1 
…-retrieve-the-os-details-about-the-current-system
@hulto hulto merged commit 21563f3 into main Jul 22, 2023
8 checks passed
@hulto hulto deleted the 237-implement-eldritch-sysget_os-function-to-retrieve-the-os-details-about-the-current-system branch July 22, 2023 20:16
hulto added a commit that referenced this pull request Sep 30, 2023
@hulto
Implement sys.get_os (#238)
514e6ef 
* Implemented, tested, documented.

* Fix lib test.
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
2dfa296 
 
Implement sys.get_os (#238)

* Implemented, tested, documented.

* Fix lib test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cictrone Cictrone Cictrone approved these changes

Assignees
No one assigned
Labels
eldritch Related to the Eldritch language feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement eldritch sys.get_os function to retrieve the os details about the current system.
2 participants
@hulto @Cictrone