Rename everything #263
Merged
Rename everything #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 75.06% 73.40% -1.66%
==========================================
Files 87 87
Lines 5302 5276 -26
==========================================
- Hits 3980 3873 -107
- Misses 1236 1317 +81
Partials 86 86
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hulto
reviewed
Aug 11, 2023
implants/imix/src/port_scan_impl.rs
Outdated
cmp5987
reviewed
Aug 11, 2023
| let tome_filename = task_job.tome.name; | ||
| let tome_contents = task_job.tome.eldritch; | ||
| let tome_parameters = task_job.parameters; | ||
| let task_quest = task.quest; |
There was a problem hiding this comment.
@hulto
Lets rename this to be more clear.
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
* session -> beacon: tavern tests pass * session -> beacon: rust & UI, all tests pass * job -> quest * Missed a few, it's good now * Removed accidentally copied port scanner
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
* session -> beacon: tavern tests pass * session -> beacon: rust & UI, all tests pass * job -> quest * Missed a few, it's good now * Removed accidentally copied port scanner
hulto
pushed a commit
that referenced
this pull request
Oct 5, 2023
* session -> beacon: tavern tests pass * session -> beacon: rust & UI, all tests pass * job -> quest * Missed a few, it's good now * Removed accidentally copied port scanner
KCarretto
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JobstoQuestsSessionstoBeaconsFixes #261