Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starlark #266

Merged
merged 6 commits into from
Aug 12, 2023
Merged

Update starlark #266

merged 6 commits into from
Aug 12, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Aug 12, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates to the latest commit of starlark rust 1109aaf9b700d7cdd7ba48986aa650221b70a22f
This puts us in v0.9.0

  • Adds support for web assembly compilation.
  • starlark ints are no longer built with Vaule::new_int(2) it's now starlark_heap.alloc(2).
  • Modules and other value types are defined with #[starlark_value(type = "assets_library")] instead of starlark_type!("assets_library");
  • GlobalsBuilder::extended() is no longer exposed and so each library extension now needs to be manually provided.
  • Should make it easier to implement custom types.

Which issue(s) this PR fixes:

@hulto hulto added cleanup Code cleanup and tech debt removal dependencies Pull requests that update a dependency file eldritch Related to the Eldritch language labels Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #266 (34ca5b3) into main (2e140fe) will decrease coverage by 0.42%.
The diff coverage is 36.11%.

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   75.22%   74.80%   -0.42%     
==========================================
  Files          87       87              
  Lines        5336     5394      +58     
==========================================
+ Hits         4014     4035      +21     
- Misses       1236     1273      +37     
  Partials       86       86              
Files Changed Coverage Δ
implants/lib/eldritch/src/assets.rs 47.61% <0.00%> (-3.67%) ⬇️
implants/lib/eldritch/src/file.rs 62.50% <0.00%> (-2.32%) ⬇️
implants/lib/eldritch/src/pivot.rs 58.26% <0.00%> (-1.90%) ⬇️
implants/lib/eldritch/src/process.rs 34.21% <0.00%> (-4.03%) ⬇️
implants/lib/eldritch/src/sys.rs 52.63% <0.00%> (-3.98%) ⬇️
implants/lib/eldritch/src/sys/exec_impl.rs 83.01% <0.00%> (ø)
implants/golem/src/inter/eval.rs 41.99% <6.55%> (-3.55%) ⬇️
implants/lib/eldritch/src/pivot/ssh_exec_impl.rs 69.56% <50.00%> (ø)
implants/golem/src/inter.rs 46.93% <100.00%> (ø)
implants/lib/eldritch/src/file/list_impl.rs 94.28% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor suggestion

implants/Cargo.toml Show resolved Hide resolved
implants/lib/eldritch/src/lib.rs Outdated Show resolved Hide resolved
@hulto hulto merged commit 268b091 into main Aug 12, 2023
6 of 8 checks passed
@hulto hulto deleted the update-starlark branch August 12, 2023 22:31
hulto added a commit that referenced this pull request Sep 30, 2023
* eldritch update to starlark 1109aaf

* Re-add extended dialect.

* All tests pass.

* Remove unused imports.

* Surpress warnings starlark macros add.
hulto added a commit that referenced this pull request Sep 30, 2023
* eldritch update to starlark 1109aaf

* Re-add extended dialect.

* All tests pass.

* Remove unused imports.

* Surpress warnings starlark macros add.
hulto added a commit that referenced this pull request Oct 5, 2023
* eldritch update to starlark 1109aaf

* Re-add extended dialect.

* All tests pass.

* Remove unused imports.

* Surpress warnings starlark macros add.
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Update starlark (#266)

* eldritch update to starlark 1109aaf

* Re-add extended dialect.

* All tests pass.

* Remove unused imports.

* Surpress warnings starlark macros add.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup and tech debt removal dependencies Pull requests that update a dependency file eldritch Related to the Eldritch language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants