-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update starlark #266
Merged
Merged
Update starlark #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulto
added
cleanup
Code cleanup and tech debt removal
dependencies
Pull requests that update a dependency file
eldritch
Related to the Eldritch language
labels
Aug 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
==========================================
- Coverage 75.22% 74.80% -0.42%
==========================================
Files 87 87
Lines 5336 5394 +58
==========================================
+ Hits 4014 4035 +21
- Misses 1236 1273 +37
Partials 86 86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Cictrone
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one minor suggestion
hulto
added a commit
that referenced
this pull request
Sep 30, 2023
* eldritch update to starlark 1109aaf * Re-add extended dialect. * All tests pass. * Remove unused imports. * Surpress warnings starlark macros add.
hulto
added a commit
that referenced
this pull request
Sep 30, 2023
* eldritch update to starlark 1109aaf * Re-add extended dialect. * All tests pass. * Remove unused imports. * Surpress warnings starlark macros add.
hulto
added a commit
that referenced
this pull request
Oct 5, 2023
* eldritch update to starlark 1109aaf * Re-add extended dialect. * All tests pass. * Remove unused imports. * Surpress warnings starlark macros add.
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cleanup
Code cleanup and tech debt removal
dependencies
Pull requests that update a dependency file
eldritch
Related to the Eldritch language
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates to the latest commit of starlark rust
1109aaf9b700d7cdd7ba48986aa650221b70a22f
This puts us in
v0.9.0
Vaule::new_int(2)
it's nowstarlark_heap.alloc(2)
.#[starlark_value(type = "assets_library")]
instead ofstarlark_type!("assets_library");
Which issue(s) this PR fixes: