Differentiate IP Crate for Windows and Nix #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 74.16% 74.26% +0.10%
==========================================
Files 89 89
Lines 5795 5818 +23
==========================================
+ Hits 4298 4321 +23
Misses 1411 1411
Partials 86 86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jabbate19
changed the title
hulto
approved these changes
Aug 15, 2023
| @@ -55,6 +66,27 @@ fn create_dict_from_interface(starlark_heap: &Heap, interface: NetInterface) -> | |||
| Ok(tmp_res) | |||
| } | |||
|
|
|||
| #[cfg(not(target_os = "windows"))] | |||
| fn create_dict_from_interface(starlark_heap: &Heap, interface: NetworkInterface) -> Result<Dict>{ | |||
There was a problem hiding this comment.
Hmm could we Abstract this type out or just move the function to take the three params. Don't love having two separate dictionary functions.
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
* Differentiate for Windows and Nix * Conditional Deps * Fix Cargo order
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
* Differentiate for Windows and Nix * Conditional Deps * Fix Cargo order
hulto
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Differentiate for Windows and Nix * Conditional Deps * Fix Cargo order
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
/kind cleanup
/kind api-change
/kind eldritch-function
What this PR does / why we need it:
Limits use of the
network_interfacecrate to windows only. Allows realm to be FreeBSD compatible.Which issue(s) this PR fixes:
N/A