Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think this fixes json formatting. #278

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Aug 17, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Fixes some small issues with our docs.

Which issue(s) this PR fixes:

Fixes #268

@hulto hulto added the documentation Improvements or additions to documentation label Aug 17, 2023
@hulto hulto linked an issue Aug 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #278 (0811d67) into main (c682ff9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   74.33%   74.33%           
=======================================
  Files          90       90           
  Lines        5844     5844           
=======================================
  Hits         4344     4344           
  Misses       1414     1414           
  Partials       86       86           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto hulto requested a review from jabbate19 August 18, 2023 16:56
Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit pick but LGTM

docs/_docs/user-guide/eldritch.md Outdated Show resolved Hide resolved
@hulto hulto merged commit da8db27 into main Aug 31, 2023
8 checks passed
@hulto hulto deleted the 268-eldritch-docs-page-is-busted branch August 31, 2023 04:26
hulto added a commit that referenced this pull request Sep 30, 2023
hulto added a commit that referenced this pull request Sep 30, 2023
hulto added a commit that referenced this pull request Oct 5, 2023
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
I think this fixes json formatting. (#278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eldritch docs page is busted
2 participants