Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed UI & Login Redirects #280

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Embed UI & Login Redirects #280

merged 4 commits into from
Sep 6, 2023

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Embeds our ReactJS UI into the compiled tavern binary
  • Creates a route to host the UI
  • Moves the playground to "/playground"
  • Redirects unauthenticated requests for the UI or playground to the OAuth login

Which issue(s) this PR fixes:

Fixes #232 (we don't seem to need a login page, just automatically redirect folks to the OAuth flow and let Google handle it)

@KCarretto KCarretto requested a review from hulto September 5, 2023 18:50
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheeeesh

tavern/app.go Show resolved Hide resolved
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise LGTM.

@KCarretto KCarretto merged commit 79dbc9b into main Sep 6, 2023
3 of 6 checks passed
@KCarretto KCarretto deleted the embed-ui branch September 6, 2023 01:27
hulto pushed a commit that referenced this pull request Sep 30, 2023
hulto pushed a commit that referenced this pull request Sep 30, 2023
hulto pushed a commit that referenced this pull request Oct 5, 2023
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
Embed UI & Login Redirects (#280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a login screen with Google OAuth
3 participants