Update devcontainer.json, improve default extensions/settings #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage 74.84% 74.84%
=======================================
Files 94 94
Lines 6106 6106
=======================================
Hits 4570 4570
Misses 1450 1450
Partials 86 86 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hulto
reviewed
Sep 6, 2023
| "rust-lang.rust-analyzer", | ||
| "sourcegraph.sourcegraph", | ||
| "vscode-icons-team.vscode-icons", | ||
| "xaver.clang-format", |
There was a problem hiding this comment.
What are we using the clang format extension for?
hulto
reviewed
Sep 6, 2023
| "HashiCorp.terraform", | ||
| "rust-lang.rust-analyzer", | ||
| "sourcegraph.sourcegraph", | ||
| "vscode-icons-team.vscode-icons", |
There was a problem hiding this comment.
Oh my. This could be kinda toxic but we'll see.
hulto
reviewed
Sep 6, 2023
| "GraphQL.vscode-graphql-syntax", | ||
| "HashiCorp.terraform", | ||
| "rust-lang.rust-analyzer", | ||
| "sourcegraph.sourcegraph", |
hulto
reviewed
Sep 6, 2023
| "DavidAnson.vscode-markdownlint", | ||
| "golang.Go", | ||
| "graphql.vscode-graphql", | ||
| "GraphQL.vscode-graphql-syntax", |
There was a problem hiding this comment.
Is this required with the other one?
hulto
approved these changes
Sep 6, 2023
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
hulto
pushed a commit
that referenced
this pull request
Oct 5, 2023
KCarretto
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our
devcontainer.jsonto install basic extensions and have some better default settings. This should help enable consistency in our codebase (and avoid misc whitespace characters from plaguing our code).