Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to internal #283

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Move to internal #283

merged 2 commits into from
Sep 6, 2023

Conversation

KCarretto
Copy link
Collaborator

Moves ent, graphql, auth, and namegen packages to tavern/internal to help better organize code and reduce exposed API surface.

@KCarretto KCarretto requested a review from hulto September 6, 2023 18:18
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #283 (1c597db) into main (483225e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   74.84%   74.84%           
=======================================
  Files          94       94           
  Lines        6106     6106           
=======================================
  Hits         4570     4570           
  Misses       1450     1450           
  Partials       86       86           
Files Changed Coverage Δ
tavern/app.go 56.89% <ø> (ø)
tavern/config.go 65.68% <ø> (ø)
tavern/internal/auth/context.go 0.00% <ø> (ø)
tavern/internal/auth/middleware.go 0.00% <ø> (ø)
tavern/internal/auth/oauth.go 66.66% <ø> (ø)
tavern/internal/cdn/download.go 90.32% <ø> (ø)
tavern/internal/cdn/upload.go 70.00% <ø> (ø)
tavern/internal/ent/schema/beacon.go 72.61% <ø> (ø)
tavern/internal/ent/schema/file.go 88.33% <ø> (ø)
tavern/internal/ent/schema/mixin_history.go 100.00% <ø> (ø)
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KCarretto KCarretto merged commit 6ed6428 into main Sep 6, 2023
8 checks passed
@KCarretto KCarretto deleted the move-to-internal branch September 6, 2023 22:49
hulto pushed a commit that referenced this pull request Sep 30, 2023
hulto pushed a commit that referenced this pull request Sep 30, 2023
hulto pushed a commit that referenced this pull request Oct 5, 2023
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
Move to internal (#283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants