Tf deploy custom container #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 74.84% 74.84%
=======================================
Files 94 94
Lines 6105 6106 +1
=======================================
+ Hits 4569 4570 +1
Misses 1450 1450
Partials 86 86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmp5987
approved these changes
Oct 3, 2023
hulto
added a commit
that referenced
this pull request
Oct 5, 2023
* Fixing ui apollo ref * Rebuild UI * Automate embed.go creation * Switch to catch-all for requests without a file
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
/kind feature
What this PR does / why we need it:
This PR implements a tavern_container_image variable to enable non kcarretto containers to be used.
This PR also resolves minor issues with the UI:
http://localhost:80/graphqlhas been switched/graphqlembed.gofile which is required to embed the compiled ui into the go binary. This has been fixed by copying a template of the embed.go file oncenpm run buildfinishesRelated docs have been updated.
Which issue(s) this PR fixes:
Fixes #285 #286 #288