Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cp/quest details page #293

Merged
merged 7 commits into from
Sep 30, 2023
Merged

Cp/quest details page #293

merged 7 commits into from
Sep 30, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Sep 30, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Lays the foundation for a quest table, provides clickable row to navigate to details for quests.
We still need to add empty states and filtering to this page.

Screenshot

Screenshot 2023-09-29 at 9 23 28 PM

@cmp5987 cmp5987 requested a review from hulto September 30, 2023 01:23
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #293 (3a5f461) into main (7d9dcb2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   74.84%   74.84%           
=======================================
  Files          94       94           
  Lines        6105     6105           
=======================================
  Hits         4569     4569           
  Misses       1450     1450           
  Partials       86       86           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmp5987 cmp5987 merged commit 38c1d60 into main Sep 30, 2023
8 checks passed
@cmp5987 cmp5987 deleted the cp/quest-details-page branch September 30, 2023 02:09
hulto added a commit that referenced this pull request Oct 5, 2023
* fix(drawer): Testing drawer component

* fix(drawer): Add drawer details

* fix(quest): Add quest table

* fix(path): Change link path and remove local host

* fix(build): Ran Build

---------

Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Cp/quest details page (#293)

* fix(drawer): Testing drawer component

* fix(drawer): Add drawer details

* fix(quest): Add quest table

* fix(path): Change link path and remove local host

* fix(build): Ran Build

---------

Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants