Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(host-ip): Add random gen for hostIP and display host IP #322

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Oct 12, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds a random IP generator for mock data
  • Gets hostIP for beacons
  • Displays hostIP for beacons

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #322 (d701751) into main (94c045b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   74.90%   74.93%   +0.03%     
==========================================
  Files          94       94              
  Lines        6112     6121       +9     
==========================================
+ Hits         4578     4587       +9     
  Misses       1447     1447              
  Partials       87       87              
Files Coverage Δ
tavern/test_data.go 98.84% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmp5987 cmp5987 merged commit 4d18ec8 into main Oct 12, 2023
8 checks passed
@cmp5987 cmp5987 deleted the cp/hostname-and-ip branch October 12, 2023 18:35
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
fix(host-ip): Add random gen for hostIP and display host IP (#322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants