-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
318 implement pivotssh copy #323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbate19
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ball
Prolly need to implement a remove function in the ssh test server. |
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
==========================================
- Coverage 74.93% 74.75% -0.19%
==========================================
Files 94 95 +1
Lines 6121 6346 +225
==========================================
+ Hits 4587 4744 +157
- Misses 1447 1515 +68
Partials 87 87
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hulto
added a commit
that referenced
this pull request
Oct 15, 2023
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
This PR adds the
pivot.ssh_copy
function to eldritch. This function is helpful for us so we can move files from one host to another allowing for initial deployment during Red v Blue training events.Which issue(s) this PR fixes:
Fixes #318