Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

269 add docs andor run time error for reserved names #334

Merged
merged 7 commits into from
Oct 30, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Oct 28, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR add notes about name shadowing the the eldritch user docs to avoid common mistakes such as for file in file.list()

Which issue(s) this PR fixes:

Fixes #269

@hulto hulto linked an issue Oct 28, 2023 that may be closed by this pull request
@hulto hulto added the documentation Improvements or additions to documentation label Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #334 (fbff540) into main (144329a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   75.38%   75.38%           
=======================================
  Files         103      103           
  Lines        6732     6732           
=======================================
  Hits         5075     5075           
  Misses       1570     1570           
  Partials       87       87           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto hulto merged commit 753bd6a into main Oct 30, 2023
8 checks passed
@hulto hulto deleted the 269-add-docs-andor-run-time-error-for-reserved-names branch October 30, 2023 00:16
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
269 add docs andor run time error for reserved names (#334)

* Add docs about name shadowing.

* Add comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs and/or run time error for reserved names
2 participants