Created core ents and implemented createJob mutation #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulto
requested changes
Nov 22, 2022
| entgql.Skip(entgql.SkipMutationCreateInput), | ||
| ). | ||
| Comment("Bundle file that the executing tome depends on (if any)"). | ||
| Unique(), |
There was a problem hiding this comment.
Is this the file resources used inside the tome?
| @@ -15,13 +15,30 @@ type Task struct { | |||
| // Fields of the Task. | |||
| func (Task) Fields() []ent.Field { | |||
| return []ent.Field{ | |||
| field.String("name"). | |||
There was a problem hiding this comment.
No task names? Are we only using the unique ID to reference tasks?
There was a problem hiding this comment.
Jobs have the name, and tasks have an edge to the job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Updates our ents, adds appropriate fields, uses mixins and hooks for optimal code reuse and bug avoidance, and implements the
createJobmutation (with tests!).Which issue(s) this PR fixes:
Maybe I should make issues first