63 feature eldritch filetemplate starlarkdict #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulto
force-pushed
the
63-feature-eldritch-filetemplate-starlarkdict
branch
from
1295f8b
to
d5f0747
Compare
…/github.com/kcarretto/realm into 63-feature-eldritch-filetemplate-starlarkdict
Cictrone
approved these changes
Feb 8, 2023
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
63 feature eldritch filetemplate starlarkdict (#84) * Latest version of starlark rust throws issues. * Rebased is_file in * No more warnings. All tests pass. * Pinning git commit. * Build works, tests pass. * Rebased * Rebasing * Rebasing * Rebasing * Trying to get starlark dicts working. rebased. * rebase and working on nested dict * Merged * Removed merge artifact * Testing dictionary creation. * Cleaned up code. * Cleaning up * All tests pass * Latest version of starlark rust throws issues. * Rebased is_file in * No more warnings. All tests pass. * Rebased * Rebasing * Rebasing * Rebasing * Trying to get starlark dicts working. rebased. * rebase and working on nested dict * Merged * Removed merge artifact * Testing dictionary creation. * Cleaned up code. * Cleaning up * All tests pass * Reverted rust version * Resolving comments from nick. * CI again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a jinja2 file templating feature to eldritch using the Tera crate.
Which issue(s) this PR fixes:
Fixes #63