LIB_INSTALL_DIR set to a Relative Path

[dMaggot]

Hi, I noticed that you set the LIB_INSTALL_DIR variable in line 123 of GammaRay-1.3.0/CMakeList.txt to a relative path. This triggers some security warnings in Gentoo when installing the package. Is this intended or can it be changed to /usr/lib${LIBSUFFIX}?

[steveire]

Hi,

What is the security warning? Don't all KDE applications also install to paths relative to CMAKE_INSTALL_PREFIX? Is this problem unique to GammaRay?

Thanks,

Steve.

[krf]

If CMAKE_INSTALL_PREFIX is set to "/usr" everything should be as you expect it.

[dMaggot]

Then it's probably a CMake bug, because if you set LIB_INSTALL_DIR to "lib" then that's what goes to the rpath, and not the complete "/usr/lib" path. The security warning is related to setting a relative path in the rpath.

[krf]

Stephen, you're the CMake guy. Does it make sense to set LIB_INSTALL_DIR to an absolute path?

[dMaggot]

If it's a CMake bug, then your cue is here

http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmComputeLinkInformation.cxx;h=08cdcb5b81362411fc42da1d094fe64a136f4613;hb=HEAD#l1813

probably worth to check if at that point you have a relative path or an absolute path and, if relative, then you want to append the CMAKE_INSTALL_PREFIX thing.

[steveire]

Please file a bug report upstream with a minimal testcase: http://public.kitware.com/Bug/main_page.php

(Note: minimal means don't say 'build gammaray' :) )

[dMaggot]

Here's the relevant conclusion of the discussion up at CMake

http://www.cmake.org/pipermail/cmake/2013-February/053467.html

[vkrause]

FindKDE4Internal.cmake indeed messes with CMAKE_INSTALL_RPATH (which needs an absolute path). Rather than changing our in my understanding correct relative install dirs, shouldn't it be enough to fix CMAKE_INSTALL_RPATH after find_package(KDE4) (i.e prepend CMAKE_INSTALL_PREFIX if necessary), and possibly fix this for real inside FindKDE4Internal.cmake?

Hm, actually, I'm wondering if RPATHs aren't even harmful for us, since the probe will always be using the libs loaded by the host application, never pull them in on its own. So, maybe we should just disable RPATH handling again after loading the KDE4 stuff?

[steveire]

Re-opening while we figure out what the real solution is.

[krf]

Did we figure out a solution for this?

[vkrause]

A workaround has been committed to the 1.3 branch.

[krf]

So I'm assuming this fixed. Closing.