Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why GAMMARAY_PROBE_ONLY_BUILD implies skipping install? #932

Open
Kentzo opened this issue Jan 17, 2024 · 2 comments
Open

Why GAMMARAY_PROBE_ONLY_BUILD implies skipping install? #932

Kentzo opened this issue Jan 17, 2024 · 2 comments
Labels

Comments

@Kentzo
Copy link
Contributor

Kentzo commented Jan 17, 2024

What is the principal reason for skipping installation of headers, pri and cmake files in probe-only builds? In my fork I allowed this installation and nothing bad happened, generated files seem appropriate.

Take a look at #929, I wonder if this extra variable is necessary at all.

@Kentzo
Copy link
Contributor Author

Kentzo commented Jan 18, 2024

My particular problem is that header for the static probe will never get installed.

@Kentzo
Copy link
Contributor Author

Kentzo commented Jan 24, 2024

It's feasible to resolve this installation issue + provide better linking experience for static plugins that avoids manual [Q_IMPORT_PLUGIN](https://doc.qt.io/qt-6/qtplugin.html#Q_IMPORT_PLUGIN) (at least for Qt6 users).

I will make a PR once all preliminary changes get merged into the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants