Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct variant in the top-level example #1

Merged
merged 2 commits into from Mar 22, 2024
Merged

Conversation

KDFJW
Copy link
Owner

@KDFJW KDFJW commented Mar 22, 2024

The example currently uses Semantics::Coupled, which is frequently selected as the default. However, this specific algorithm is order-agnostic (able to correctly operate with the relaxed ordering). So, the semantics are needlessly restrictive. This updates the variant to Semantics::Relaxed

Copy link
Owner Author

@KDFJW KDFJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KDFJW
Copy link
Owner Author

KDFJW commented Mar 22, 2024

It doesn't. Forgot the SemVer

@KDFJW KDFJW closed this Mar 22, 2024
@KDFJW KDFJW reopened this Mar 22, 2024
Copy link
Owner Author

@KDFJW KDFJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we're talking

@KDFJW KDFJW merged commit 8f0726a into main Mar 22, 2024
@KDFJW KDFJW deleted the doc/fix-semantics branch March 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant