Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"잠재능력 재설정 불가" variable missing newline #5

Closed
Sunaries opened this issue Jan 4, 2017 · 2 comments
Closed

"잠재능력 재설정 불가" variable missing newline #5

Sunaries opened this issue Jan 4, 2017 · 2 comments

Comments

@Sunaries
Copy link

Sunaries commented Jan 4, 2017

Greetings,

ingame
↑ The above image is an in-game version. As you can see there is a new line after "Unique Equipped Item"

current version
↑ Current version of yours does not seem to do this.

P.S. I also noticed that the potential says Legendary (L) while in-game says Unique (U). Error?

P.P.S:

test

Though it does not have a newline for this item. Hmm...

@KENNYSOFT
Copy link
Owner

KENNYSOFT commented Jan 5, 2017

Thanks for reporting. However, I already noticed these bugs, also in same item. My comment (in Korean) for this item can be found in 인소야닷컴(http://www.insoya.com/bbs/zboard.php?id=maple_info&no=35668).

The first bug is because of the orange properties length. The properties doesn't make newline by its property itself(like 잠재능력 재설정 불가), but make newline if whole properties line is longer than some specific value(this version has 255 in GearTooltipRender2.cs:216). So the first one is easily resolved by adjusting that value.

The second bug has relation with "fixedGrade" value, which is 5 for this item. However, I have searched for fixedGrade value in whole item of KMS, the fixedGrade value is only in 2, 3, 5, which is rare(blue) color, epic(purple) color, and unique(yellow) color, respectively. Besides, this program assumes the fixedGrade value 2, 3, 4, 5 as rare, epic, unique, and legendary(in Gear.cs:572-575), respectively. If I have some different values for fixedGrade(especially about in-game legendary fixed item), then I should fix this bug.

Also, I will fix the ExclusiveEquip list and SetItemTooltip to not show same named items duplicated.

@KENNYSOFT
Copy link
Owner

KENNYSOFT commented Jan 5, 2017

The first bug is resolved with replacing 255 to 254. Also duplicated name is deleted.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants