Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] User Properties Dialog Crashes #1706

Closed
Kazzz-S opened this issue May 9, 2024 · 11 comments · Fixed by #1708
Closed

[macOS] User Properties Dialog Crashes #1706

Kazzz-S opened this issue May 9, 2024 · 11 comments · Fixed by #1708
Assignees
Labels
Milestone

Comments

@Kazzz-S
Copy link
Contributor

Kazzz-S commented May 9, 2024

1. The Latest Version (0.29.1)

The User Properties dialog crashes when I click the [User Properties] button.
This problem reproduces with the latest four binaries listed below.
0291DMGs
02901-crash-logs.zip

I used this feature before. I recently started using it again after a long hiatus and noticed this problem.

This problem is macOS-specific.
This feature works as expected in the Linux and Windows environments, as shown in the images below.
OK-Linux-Mint21 3
OK-Windows10

To be continued...

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented May 10, 2024

Cont.

2. Previous Versions (< 0.29.1)

I tested previous versions with HW*.dmg going back in history.
Then, I found versions up to 0.28.8 are problematic.

<0.29.1> --> 0.28.17 --> 0.28.15 --> 0.28.14 --> 0.28.13 --> 0.28.12 --> 0.28.11 --> 0.28.10 --> 0.28.9 --> 0.28.8

previous-crash-logs.zip

To be continued...

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented May 10, 2024

Cont.

3. Further Previous Versions (< 0.28.8)

I tested with 0.28.7, 0.27.13, and 0.26.12 and found they are OK, as shown in the sample images below.
02807HW-a
02807HW-b
OK-samples.zip

I suspect some problem may have intruded between 0.28.7 and 0.28.8.

Best regards,
Kazzz-S

@klayoutmatthias
Copy link
Collaborator

Thanks for the analysis. I will look into that.

Matthias

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented May 11, 2024

Cont.

4. With Qt6

  • It works with Qt6!
  • These two DMGs have not been officially published.

02901-ST-Qt6

02910-HWports-Qt6

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented May 11, 2024

Cont.

5. Qt-wise Status

Qts

Qts.xlsx

Thanks,
Kazzz-S

@stefanottili
Copy link

on M1 lastest master:
homebrew qt 5.15.13 coredump
homebrew qt 6.7 works

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented May 12, 2024

Dear @Kazzz-S and @stefanottili

Thanks for the many datapoints and your experiments!

Maybe I found the root cause: on some platforms / compilers, a default-initialized iterator appears no to have the same value. I think it is more related to the compiler, although I have not seen the issue myself on neither gcc nor clang on Linux and Windows. Searching does not reveal a consistent picture: some say, a default-initialized constructor is a "singular" value, others say it is uninitialized. So it is better to give it a proper value.

My patch is here: #1708

Maybe you can try whether this fixes the problem.

Thanks and best regards,

Matthias

@klayoutmatthias
Copy link
Collaborator

P.S: I hope you did not spend too much effort in your research. Basically all I needed was the hint about 0.28.7 vs. 0.28.8 :(

@stefanottili
Copy link

git checkout origin/bugfix/issue-1706 fixes the coredump on M1 Sonoma.

The fact that it went unreported for so many versions just might indicate that nobody is using this feature ...

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented May 13, 2024

Hello @klayoutmatthias,

Thank you for trying to fix this problem.
Using the patch #1708, I rebuilt:

  1. Four binaries with Qt5.x mentioned in this table.
  2. Two binaries with Qt6.x mentioned in this comment.
  3. One binary with Qt5.12.8 on Linux Mint 20.3.

I confirmed that all 7 test cases are OK.

Thank you again, and best regards,
Kazzz-S

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented May 13, 2024

Hello @stefanottili,

Thank you for testing on M1 Sonoma.
I use this feature mainly in Linux environments, so I overlooked this problem till recently.

Best regards,
Kazzz-S

@klayoutmatthias klayoutmatthias self-assigned this May 13, 2024
@klayoutmatthias klayoutmatthias added this to the 0.29.2 milestone May 13, 2024
klayoutmatthias added a commit that referenced this issue May 31, 2024
Trying to fix bug #1706 (crash on user properties form)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants