Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format problem with QMessageLogger::critical etc. #933

Closed
klayoutmatthias opened this issue Nov 10, 2021 · 1 comment · Fixed by #934
Closed

Fix format problem with QMessageLogger::critical etc. #933

klayoutmatthias opened this issue Nov 10, 2021 · 1 comment · Fixed by #934

Comments

@klayoutmatthias
Copy link
Collaborator

As suggested by this PR: #932

However, the solution is not by patching the generated file. This will not be sustainable. The solution is to apply a custom mapping for this function. However, the mapping scheme does not support variable-number arguments, so only the proposed single-string mapping will be available.

Workaround is to replace "%" in message text to "critical" etc. by "%%".
@klayoutmatthias klayoutmatthias mentioned this issue Nov 10, 2021
Closed
@klayoutmatthias klayoutmatthias changed the title Fix format problem with QMessage::critical etc. Fix format problem with QMessageLogger::critical etc. Nov 10, 2021
@klayoutmatthias klayoutmatthias linked a pull request Nov 13, 2021 that will close this issue
Alternative fix using a customized implementation for QMessageLogger … #934
Merged
@klayoutmatthias
Copy link
Collaborator Author

Fixed by PR #934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alternative fix using a customized implementation for QMessageLogger … KLayout/klayout
1 participant
@klayoutmatthias