Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manaan East Central - A script is checking for the wrong file #344

Closed
Salk73 opened this issue Nov 12, 2019 · 3 comments
Closed

Manaan East Central - A script is checking for the wrong file #344

Salk73 opened this issue Nov 12, 2019 · 3 comments
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Manaan Issue occurs primarily on Manaan Type: Scripting This issue is related specifically to a scripting bug/error

Comments

@Salk73
Copy link

Salk73 commented Nov 12, 2019

The global k_pman_planet45.ncs script checks for an item that is apparently unused in the game. It makes sense that we check instead for the passcard (w_sithkey.uti).

int StartingConditional()
{
    int iResult;

    iResult = (GetIsObjectValid(GetItemPossessedBy(GetPCSpeaker(), "w_sithkey")) == TRUE);

    return iResult;
}
@DarthParametric DarthParametric added Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Manaan Issue occurs primarily on Manaan Type: Scripting This issue is related specifically to a scripting bug/error labels Nov 13, 2019
@DarthParametric
Copy link
Contributor

DarthParametric commented Nov 13, 2019

MAN_REPTECH1_DONE being false is a check in the starting conditional (k_pman_planet85) for one of the nodes in the Republic Technician's DLG Hey, great! You sliced the encryption on those cards! They change the codes regularly, so you'll have to use it pretty soon or not at all. so you don't want to include that. It can be switched to a local boolean if needs be.

@Salk73
Copy link
Author

Salk73 commented Nov 13, 2019

Oh okay, good.

The vanilla script included that check so I let it be but I should have known better. Thanks for the heads-up. We can even just remove it altogether without bothering to replace it with any local variable.

@DarthParametric
Copy link
Contributor

There's an existing global starting conditional that does this, k_pman_missing34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Manaan Issue occurs primarily on Manaan Type: Scripting This issue is related specifically to a scripting bug/error
Projects
None yet
Development

No branches or pull requests

2 participants