Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taris Swoop Platform - Various issues during final Brejik scene #345

Closed
8 tasks done
DarthParametric opened this issue Nov 13, 2019 · 3 comments
Closed
8 tasks done
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Taris Issue occurs primarily on Taris Type: Conversation This issue is a DLG-specific bug/error Type: Module This issue involves changes to a module's properties (ARE, GIT, IFO, LYT, and VIS files). Type: Scripting This issue is related specifically to a scripting bug/error

Comments

@DarthParametric
Copy link
Contributor

DarthParametric commented Nov 13, 2019

When the announcer berates Brejik about retracting the prize, there is some camera wobble due to Brejik being the listener and rotating from facing the player to facing the announcer. The best solution is to switch to a static camera for that shot. Edit: Actually, the cause was a script forcing a facing change on the announcer on that node. Moving it to a previous node to do it off-screen solves the issue.

Edit 2: While we're at it, I spy several more issues with that scene. The full list:

  • Camera wobble on Entry 13 (Announcer's "You can't do this, Brejik!").
  • Brejik spawns in facing straight ahead rather than towards the player. Edit: Actually the waypoint faces the right way. Might be due to the player's initial position.
  • The player ends up facing straight ahead after the intro sequence, not faced towards Brejik.
  • Brejik spawns in with a blaster equipped. Might be better to have him equip it post-scene.
  • Brejik switches facing between Bastila and the Player during consecutive Entries 11 & 12.
  • Some fans are spawned to cheer for the player, but they disappear halfway through the scene.
  • After exiting the scene, Brejik snaps 180° to face the player due to the change in the exit script. Might need to face him that way on the final node/s.
  • Bastila can end up frozen in the background in the final line of the scene.

Bastila's kick to the back of the guard's head doesn't quite make contact.

Edit 3: I don't think the Bastila kick issue is really solvable, since it is dynamic rather than using cutscene anims. If you push the mook too close the cage, he gets Force Pushed in the opposite direction. There's also a point at the closest he can get while still going in the right direction where he seems to consistently end up sideways. So I have nudged him a little closer, but she still doesn't really make contact (and given the height discrepancies and the maximum lift of the leg, I don't think she ever could properly outside of a custom cutscene anim).

Edit 4: The player gets their weapons re-equipped on Brejik's final line. While they will perform an equip flourish, they apparently refuse to go into a looping ready animation for the duration of the line. Possibly that can be readdressed at some point in the future.

Edit 5: Further playing with the player at the end of the scene, it doesn't seem like the game will co-operate in having them perform the ready animation. Possibly it is related to how they are re-equipped from the item storage, despite it essentially just boiling down to an ActionEquipItem the same as Brejik. Whatever the root cause, it doesn't appear to work regardless of single/dual wield or ranged/melee, even when equipping them instantly on an earlier node.

Split out from #301.

1.9.0 observations:
Bastila's kick needs a sound effect. Edit: Seems there is a SFX on a subsequent test.

@DarthParametric DarthParametric added Type: Conversation This issue is a DLG-specific bug/error Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Taris Issue occurs primarily on Taris Type: Module This issue involves changes to a module's properties (ARE, GIT, IFO, LYT, and VIS files). labels Nov 13, 2019
@DarthParametric DarthParametric changed the title Taris Swoop Platform - Camera wobble during final Brejik scene Taris Swoop Platform - Various issues during final Brejik scene Jun 17, 2020
@DarthParametric
Copy link
Contributor Author

DarthParametric commented Nov 7, 2020

  • Bastila appears to get frozen in her hands-on-hips pose post-conversation until combat starts and she plays an attack animation. She can be fixed by adding an anim for her in the final DLG node.

@DarthParametric
Copy link
Contributor Author

DarthParametric commented Nov 14, 2023

  • In the post-fight conversation with Bastila, if the PC didn't loot Brejik's corpse then Bastila will walk over to it and mime looting it. When this happens the PC doesn't move, so it can look a bit awkward with them blankly staring off in the opposite direction. They should get a facing command towards the corpse.
  • Brejik's corpse will disappear leaving a bodybag. He should be given a SetIsDestroyable command before the fight so that his corpse stays.

@DarthParametric DarthParametric added the Type: Scripting This issue is related specifically to a scripting bug/error label Nov 14, 2023
@DarthParametric
Copy link
Contributor Author

DarthParametric commented Nov 30, 2023

1.10.0 beta test observations:

  • Not sure how it happened, but Brejik wasn't interactable after he died, meaning I couldn't loot him. Not the end of the world since Bastila can loot him for you, but still a bug. Edit: The addition of SetIsDestroyable is the culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Taris Issue occurs primarily on Taris Type: Conversation This issue is a DLG-specific bug/error Type: Module This issue involves changes to a module's properties (ARE, GIT, IFO, LYT, and VIS files). Type: Scripting This issue is related specifically to a scripting bug/error
Projects
None yet
Development

No branches or pull requests

1 participant