Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juhani lacks a soundset in the grove #41

Closed
JCarter426 opened this issue Mar 2, 2019 · 1 comment
Closed

Juhani lacks a soundset in the grove #41

JCarter426 opened this issue Mar 2, 2019 · 1 comment
Assignees
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Dantooine Issue occurs primarily on Dantooine

Comments

@JCarter426
Copy link
Contributor

(reported by ebmar)

When the player fights Juhani in the grove, she lacks a soundset. Alas, the fix isn't as simple as assigning Juhani her usual soundset, as it contains lines such as "For the Order!" and "THAT is what a Jedi can do!" and it wouldn't make sense for her to say such things in that situation. Making a new SSF file that excludes these lines is easy enough, and I've done that, but the implementation would be messy. It would require a 2DA edit and one or two TSLPatcher tokens. That makes me wonder if it's worth it for the Community Patch, but it could be done.

@JCarter426 JCarter426 added Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Dantooine Issue occurs primarily on Dantooine labels Mar 2, 2019
@DarthParametric
Copy link
Contributor

It's not really that messy. We are already editing appearance.2da and the Grove module anyway. I think it would be fine as a Tier 3 option.

@JCarter426 JCarter426 self-assigned this Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Dantooine Issue occurs primarily on Dantooine
Projects
None yet
Development

No branches or pull requests

2 participants