Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jagi's journal entry is not removed post-Tatooine showdown #518

Closed
1 task done
DarthParametric opened this issue Nov 30, 2021 · 2 comments
Closed
1 task done

Jagi's journal entry is not removed post-Tatooine showdown #518

DarthParametric opened this issue Nov 30, 2021 · 2 comments
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Type: Quest This issue is specifically quest related. May be broken or related to Journal entries.

Comments

@DarthParametric
Copy link
Contributor

DarthParametric commented Nov 30, 2021

1.9.0 beta test observations:

  • After defeating Jagi on Tatooine, the journal entry for it is still active. Not sure if that's a vanilla issue or not. I don't recall it from prior playthroughs.
@DarthParametric DarthParametric added Minor Issue Aesthetic issue or other problem that isn't really a bug Type: Quest This issue is specifically quest related. May be broken or related to Journal entries. labels Nov 30, 2021
@DarthParametric
Copy link
Contributor Author

DarthParametric commented Dec 3, 2021

This was apparently already meant to be resolved by an edited OnDeath script from LiliArch to flag the vanilla OUD OnDeath event. Seems that didn't work this time around, although I am sure it did previously. Probably better to edit the OnSpawn instead and add the GN_SetSpawnInCondition(SW_FLAG_EVENT_ON_DEATH) flag.

Edit: His vanilla OnSpawn already has that. Curious. So his default OnDeath script should already trigger the OUD in the first place, since the OnSpawn flag is set.

@DarthParametric
Copy link
Contributor Author

Aha, I see the problem. The trigger for his encounter is spawning the global UTC (g_jagi), not the module-specific one (g_jagi001).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Type: Quest This issue is specifically quest related. May be broken or related to Journal entries.
Projects
None yet
Development

No branches or pull requests

1 participant