Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ebon Hawk - Dwindling Supplies isn't in quests until you check the container #633

Closed
ghost opened this issue Jun 22, 2022 · 1 comment
Closed
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Ebon Hawk Issue occurs primarily on the Ebon Hawk Type: Conversation This issue is a DLG-specific bug/error Type: Scripting This issue is related specifically to a scripting bug/error

Comments

@ghost
Copy link

ghost commented Jun 22, 2022

All right, take this one with a grain of salt, as I've been having problems with this module, but on my end, when you get the Dwindling Supplies quest from Zaalbar, no new entry appears in active quests until you check the supplies container.

Again, might very well be an issue on my end, and it's a bastard to check what with the previous Calo Nord cutscene and all.

@DarthParametric DarthParametric added Type: Conversation This issue is a DLG-specific bug/error Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Ebon Hawk Issue occurs primarily on the Ebon Hawk Type: Scripting This issue is related specifically to a scripting bug/error labels Jun 22, 2022
@DarthParametric
Copy link
Contributor

DarthParametric commented Jun 22, 2022

I see what the issue is. The DLG for Zaalbar initially telling you about the supplies also handles the case of Sasha leaving before you progress/resolve the quest. The exit nodes of both branches use the same script, k_pebo_zalmove, to move him back to his original position. It also removes the journal entry, which makes sense for when she leaves. Unfortunately the unintended side-effect is nuking the addition of the journal entry (state 10) that is added on the other branch.

Easily resolved by assigning R4 its own separate script. Although interestingly the other branch does set the state to 99, which presumably closes it anyway. So perhaps RemoveJournalQuestEntry can simply be removed from the script and still used on both exit nodes. I'll need to examine the JRL entries for it.

Edit: On further examination, the branch for Sasha leaving actually sets the state of k_pebo_stowaway, whereas the initial branch sets the initial state of ebo_supplies. The script removes the latter, which doesn't make any sense, but can be resolved via the aforementioned script edit. State 10 of ebo_supplies is:

Zaalbar is concerned about the emergency food stores in the Ebon Hawk's cargo hold. The
Wookiee's natural fixation on food might be causing him to worry unjustly, but you should
still check it out just to be safe.

I guess it probably depends on whether or not Zaalbar will tell you Sasha is leaving if you never actually found her, since presumably that would close ebo_supplies already. The safest route would be to split it into two separate scripts.

@DarthParametric DarthParametric added Type: Conversation This issue is a DLG-specific bug/error and removed Type: Conversation This issue is a DLG-specific bug/error labels Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Ebon Hawk Issue occurs primarily on the Ebon Hawk Type: Conversation This issue is a DLG-specific bug/error Type: Scripting This issue is related specifically to a scripting bug/error
Projects
None yet
Development

No branches or pull requests

1 participant