Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can ask Jolee about Sunry even if he hasn't talked to Elora or his messenger #641

Closed
ghost opened this issue Jun 23, 2022 · 1 comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Global Issue occurs across all modules Module: Manaan Issue occurs primarily on Manaan Type: Conversation This issue is a DLG-specific bug/error Type: Scripting This issue is related specifically to a scripting bug/error

Comments

@ghost
Copy link

ghost commented Jun 23, 2022

I basically skipped the quest: I triggered Elora's convo without Jolee in the party and told her to get lost and never brought Jolee to talk to her, neither did Jolee talk to his old pal. Even so, I can ask Jolee about Sunry, when supposedly this is the first news he's heard about him. His response doesn't make sense this way.

Submitted by muitafruita

@DarthParametric DarthParametric added Type: Conversation This issue is a DLG-specific bug/error Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Manaan Issue occurs primarily on Manaan Type: Scripting This issue is related specifically to a scripting bug/error Module: Global Issue occurs across all modules labels Dec 16, 2022
@DarthParametric DarthParametric added this to the Targeting v1.10.0 milestone Jul 22, 2023
@DarthParametric
Copy link
Contributor

DarthParametric commented Nov 13, 2023

R40 - Tell me about Sunry. How do you know him? - is gated by the starting conditional k_swg_jolee18. Since global number MAN_MURDER_PLOT is set to 1 when Elora is first spawned by the module's OnEnter, this branch will become available as soon as the player sets foot in Ahto West for the first time, regardless of other factors.

I can't find any case of the global being set to 2, so the last check could never evaluate true. Presumably that would mean that you could repeatedly ask Jolee about Sunry while the global is still set to 1, despite it being intended to be gated off by setting SW_PLOT_BOOLEAN_06 on him the first time.

It's possible that the other two Sunry branches R34 - I have a tape that shows Sunry killing Elassa. and R21 - So what do you think of Sunry's verdict? also require their starting conditionals (k_swg_jolee12 and k_swg_jolee14, respectively) to be tweaked, since they only check the state of MAN_MURDER_PLOT and a local for having asked previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Global Issue occurs across all modules Module: Manaan Issue occurs primarily on Manaan Type: Conversation This issue is a DLG-specific bug/error Type: Scripting This issue is related specifically to a scripting bug/error
Projects
None yet
Development

No branches or pull requests

1 participant