Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dantooine Enclave - Merchant Crattis Yurkal's offer #658

Closed
ghost opened this issue Jul 6, 2022 · 2 comments
Closed

Dantooine Enclave - Merchant Crattis Yurkal's offer #658

ghost opened this issue Jul 6, 2022 · 2 comments
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Dantooine Issue occurs primarily on Dantooine Type: Scripting This issue is related specifically to a scripting bug/error

Comments

@ghost
Copy link

ghost commented Jul 6, 2022

Hinted by JC to be a case of bad coding, most likely. This is not restored content: you can be given the merchant's offer to sell cave crystals in vanilla, though it is very easy to miss, since once you pass the test to be a Padawan his new greeting overrides the offer (or something to that extent).

Submitted by muitafruita

@DarthParametric DarthParametric added Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Dantooine Issue occurs primarily on Dantooine Type: Scripting This issue is related specifically to a scripting bug/error labels Jul 7, 2022
@DarthParametric
Copy link
Contributor

This is controlled by the starting conditional k_pdan_jedi08. Since it is a global script, the original Bioware comments remain intact and thus we know exactly what the designer intent was:

    Checks to see if DAN_JEDI_PLOT is 4 (meaning that the
    player has successfully cleansed the grove) and
    DAN_CRATISL_DONE is FALSE (meaning that Crattis has
    not yet offered to buy lightsaber crystals off the
    player). This conversation will not repeat since
    DAN_CRATISL_DONE is set to TRUE to show that this
    conversation has taken place.

We could change GetGlobalNumber("DAN_JEDI_PLOT") == 4 to GetGlobalNumber("DAN_JEDI_PLOT") >= 4 so that it is still available after you've advanced the main plot to/beyond the star map. But it is clear it is only meant to be a one-time offer.

@ghost
Copy link
Author

ghost commented Jul 7, 2022

Edit:

Yes, the problem seems to be that unless the player talks to him before Zhar (which I assume is not normally the case), this offer presumably never takes place, because the next time you talk to him he congratulates you for becoming a Jedi and the "Welcome to my shop" line becomes the permanent greeting from then on. From what I recall, if the player misses out on this, they also miss out on DS points as well as one of Mission's comments.

@ghost ghost changed the title Dantooine Enclave - Merchant Crattis Yukal's bugged offer Dantooine Enclave - Merchant Crattis Yurkal's offer Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Dantooine Issue occurs primarily on Dantooine Type: Scripting This issue is related specifically to a scripting bug/error
Projects
None yet
Development

No branches or pull requests

1 participant