Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star Forge - Bastila's face not shown when she speaks a line in the Dark Side ending of Carth's romance #664

Closed
Leilukin opened this issue Aug 5, 2022 · 9 comments
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Star Forge Issue occurs primarily on the Star Forge Type: Conversation This issue is a DLG-specific bug/error

Comments

@Leilukin
Copy link

Leilukin commented Aug 5, 2022

If the player has completed Carth's romance subplot and chosen the Dark Side ending, Carth will show up on the Star Forge after the player defeats Malak. When Bastila appears and says, "Don't listen to him, master! Let me strike him down! Seize your victory!!", the game will skip to the player's dialogue options while Bastila's VO of that line is playing.

To fix the issue, just add these lines in changes.ini:

[k_sta_carth.dlg]
!Destination=Modules\sta_m45aa.mod
EntryList\9\Delay=4294967295

Here is a video showing the difference before and after the fix:

Carth.Romance.DS.Ending.-.Bastila.Dialogue.Fix.mp4
@Salk73
Copy link

Salk73 commented Oct 7, 2022

As additional note of interest, I wonder if the Persuade animation at E7 is intentional? I guess it is supposed to be Carth's dismissive gesture delivered together with the "Don't interfere, Bastila. This is between me and Revan." line but it does not seem like the animation is played at all. Perhaps the Carth model does not have it.

@DarthParametric DarthParametric added Type: Conversation This issue is a DLG-specific bug/error Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Star Forge Issue occurs primarily on the Star Forge labels Dec 15, 2022
@DarthParametric
Copy link
Contributor

DarthParametric commented Dec 15, 2022

Seems like Bastila's line to the player needs a forced camera angle change to mask a pretty nasty transition. Try using 2 and see what that looks like.

P.S. I edited your post to add a blank line above the video in order for it to embed properly.

@Leilukin
Copy link
Author

Leilukin commented Dec 15, 2022

@DarthParametric Thanks for the suggestion. I changed the CameraAngle of E9 of to 2 and this is how it looks like in the game:

Star.Forge.DS.Ending.Bastila.Camera.Fix.mp4

The lines needed to be added to changes.ini would be:

[k_sta_carth.dlg]
!Destination=Modules\sta_m45aa.mod
EntryList\9\Delay=4294967295
EntryList\9\CameraAngle=2

@DarthParametric
Copy link
Contributor

Hrm. Bastila has a scripted saber blade override? Looks like that's what's causing my issue with the camera cut. You could swap out her TALK_FORCEFUL for a TALK_NORMAL so she isn't waving the blade in her face. That might look better. Although it could just be the low framerate of the capture. ~18FPS? How does it look on your end in the actual game?

@Leilukin
Copy link
Author

Yeah, on my computer K1 (at least the GOG version) at higher graphic settings tends to run below 30FPS when I do a video capture, unlike TSL (both GOG and Steam versions) which my computer has no problem with running around 60FPS even at the highest graphical settings when I do a video capture. I use Bandicam to capture screenshots and videos for both KotOR games.

I changed Bastila's animation to TALK_NORMAL and adjusted to the lowest graphic settings. This is what it looks like in my game:

swkotor.2022-12-15.17-15-46-665.mp4

TSLPatcher's ChangeEdit output for changing Bastila's animation would be EntryList\9\AnimList\0\Animation=10038

@Salk73
Copy link

Salk73 commented Dec 15, 2022

In the video above, Bastila is still using the TALK_FORCEFUL animation.

@DarthParametric
Copy link
Contributor

You can upload a save if you want and I can check it on my end, but I believe I have seen enough to go ahead with the change once the anim switch is done.

@Leilukin
Copy link
Author

Here is a save for it:
DS Female PC Ending Save.zip

@Salk73 I only changed the animation of E9 to TALK_NORMAL because it's the node that my issue focuses on, so E8 still had Bastila use the TALK_FORCEFUL animation in that video.

@DarthParametric
Copy link
Contributor

DarthParametric commented Dec 15, 2022

Yeah might need to replace the TALK_FORCEFUL on the line to Carth and then leave it on for the player, or replace them both. Let me check it on my end first and see what the camera switch looks like without anim edits.

Edit: So even switching both anims there's still a flash of the blade caused by the sudden snap turn Bastila does to face the player. But I think a camera angle switch is necessary, so the only solution would be to extinguish her saber. Not sure I want to mess with that. Also changed the angle on Revan's walk in, since the angle 1 on Carth had some wiggle.

Carth_SF_Showdown_Edit.mp4

Edit 2: Hrm, seems it doesn't like MP3 audio. Not that it matters for the purposes of this I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Star Forge Issue occurs primarily on the Star Forge Type: Conversation This issue is a DLG-specific bug/error
Projects
None yet
Development

No branches or pull requests

3 participants