Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taris Undercity - Wounded Republic Soldier's animation #666

Closed
4 tasks done
Salk73 opened this issue Aug 14, 2022 · 2 comments
Closed
4 tasks done

Taris Undercity - Wounded Republic Soldier's animation #666

Salk73 opened this issue Aug 14, 2022 · 2 comments
Labels
Low Priority Bottom of the pile Module: Taris Issue occurs primarily on Taris Type: Scripting This issue is related specifically to a scripting bug/error Type: Template This issue is related specifically to a template like a UTC. UTI, UTP, etc.

Comments

@Salk73
Copy link

Salk73 commented Aug 14, 2022

Another very minor issue.

  • The infected Republic Soldier in Taris Undercity correctly shows the injured animation when he's spawned but it doesn't keep it after he starts talking to the party. Ideally he should instead continue showing the injured animation until he is cured or until he turns into a rakghoul.

Edit: Added additional issues - DP

  • When giving the serum to the soldier, he does the inject anim before the player can reach him.
  • When giving the serum to the soldier, as he runs off after hearing a noise the party doesn't turn to look at him.
  • When giving the serum to the soldier, not all the Rakghouls attack before he dies.
@DarthParametric DarthParametric added Low Priority Bottom of the pile Module: Taris Issue occurs primarily on Taris Type: Scripting This issue is related specifically to a scripting bug/error Type: Template This issue is related specifically to a template like a UTC. UTI, UTP, etc. labels Aug 14, 2022
@DarthParametric
Copy link
Contributor

This can make use of the same additions JC made for Handon in #38.

@DarthParametric DarthParametric added this to the Targeting v1.10.0 milestone Jul 22, 2023
@DarthParametric
Copy link
Contributor

DarthParametric commented Jul 24, 2023

The anim is initiated by the soldier's UserDefine script. So he will start playing the anim on his first heartbeat tick after spawning. However, since the function then sets the local boolean to true, it won't reinitiate on subsequent ticks. He gets a TALK_INJURED anim on the first node of the DLG, but none of the subsequent ones it would seem. Judging by the empty k_ptar_repstand script on E4, it would appear the original intention was to clear the anim when given the serum (although this should now be unnecessary due to the inject anim via k_ptar_repserum on the previous node). I'll have to test what happens in that scenario, since I don't recall giving him the serum in recent playthroughs. When not giving him the serum he gets hit with EffectHorrified via k_ptar_repvic before the change to a Rakghoul.

I'll have to play through it to see what normally happens with him. I assume the first node in-DLG anim is nuking the scripted anim, so the fix might be as simple as removing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Bottom of the pile Module: Taris Issue occurs primarily on Taris Type: Scripting This issue is related specifically to a scripting bug/error Type: Template This issue is related specifically to a template like a UTC. UTI, UTP, etc.
Projects
None yet
Development

No branches or pull requests

2 participants