Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taris Sith Base Governor's Quarters - it's possible to retrigger the dialog during the fight. #790

Closed
th3w1zard1 opened this issue Mar 9, 2024 · 5 comments
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Taris Issue occurs primarily on Taris Type: Conversation This issue is a DLG-specific bug/error Type: Scripting This issue is related specifically to a scripting bug/error

Comments

@th3w1zard1
Copy link
Contributor

When you enter the room, after exiting the elevator, the sith dude greets you with 'Who dares enter...'.

Once that dialog finishes the fight begins. If you mistime your attack right at the beginning, it tries to retrigger the dialog (replays 'Who dares enter...'), causing a myriad of bugs and giving potentially unlimited dark side points. Very odd git camera behavior.

Is this something the k1cp would be willing to fix?

@DarthParametric
Copy link
Contributor

Can't recall ever encountering it, and we don't edit that module so it's presumably not an error on our part. You sure it's not from another mod?

@th3w1zard1
Copy link
Contributor Author

th3w1zard1 commented Mar 10, 2024

Yes to clarify this isn't a k1cp bug, it's a vanilla bug. You can reproduce it by attacking the guy too quickly after he finishes talking. Presumably the positional trigger is still briefly active after the dialog ends

@th3w1zard1
Copy link
Contributor Author

Possibly similar to #708

@DarthParametric
Copy link
Contributor

DarthParametric commented Mar 11, 2024

OK so it's a simple OnOpen script on the door that signals the Governor to begin a conversation via UT_NPC_InitConversation. The DLG then fires the generic k_act_atkonend which sets him hostile and fires GN_DetermineCombatRound to have him attack after 0.5 seconds.

I see two problems. The first is that the DLG is not setting a Talked To boolean to prevent that branch starting again. The second is that there clearly needs to be a NoClicksFor on the exit script to curb the behaviour of click spammers.

@th3w1zard1
Copy link
Contributor Author

Sorry I forgot to follow up here. Looking at the DLG in question I believe what your solution entails matches up with the behavior I was seeing in the bug.

@DarthParametric DarthParametric added Type: Conversation This issue is a DLG-specific bug/error Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Taris Issue occurs primarily on Taris Type: Scripting This issue is related specifically to a scripting bug/error labels Mar 20, 2024
@DarthParametric DarthParametric changed the title tar_m09ab it's possible to retrigger the dialog during the fight. Taris Sith Base Governor's Quarters - it's possible to retrigger the dialog during the fight. Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Taris Issue occurs primarily on Taris Type: Conversation This issue is a DLG-specific bug/error Type: Scripting This issue is related specifically to a scripting bug/error
Projects
None yet
Development

No branches or pull requests

2 participants