Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local steering commands still implement RT delay #1163

Closed
Gaiiden opened this issue Sep 17, 2015 · 6 comments
Closed

Local steering commands still implement RT delay #1163

Gaiiden opened this issue Sep 17, 2015 · 6 comments
Labels
invalid Devs do not agree the problem is a problem, or it's a misunderstanding.

Comments

@Gaiiden
Copy link

Gaiiden commented Sep 17, 2015

set done to false.
on AG1 { 
  set ship:control:pitch to 0.5. 
  print "pitching!". 
}. 
on AG2 { 
  set ship:control:pitch to 0. 
  set done to true. 
}. 
until done {}.

When using Action Groups Extended to bypass RemoteTech and trigger action groups immediately, the following code prints "Pitching!" as soon as AG1 is triggered but it still takes however long the signal delay is to carry out the command that changes the craft pitch control. RT integration was disabled through the kOS control panel when this script was run. Triggering the second action group ends the program immediately, but it again takes the length of the current signal delay to zero out the pitch control

@hvacengi
Copy link
Member

Interesting error. I think that this was working for me properly before, but I haven't tested it with a major delay recently. We'll get it on the list to research.

@Gaiiden
Copy link
Author

Gaiiden commented Sep 19, 2015

also I forgot to specify this is with the latest kOS and RT versions

@hvacengi
Copy link
Member

Did you have the issue with in previous versions of RT, or did it start with the most recent update?

@Gaiiden
Copy link
Author

Gaiiden commented Sep 19, 2015

I can't say, I only ever tried this recently on the newest versions. A version or few ago RT would allow local steering without signal delay using the flight controls but that was fixed sometime post KSP v1.0. I think that fix may have had this unintended effect, and may actually be a RT issue, not a kOS one

@Gaiiden
Copy link
Author

Gaiiden commented Sep 23, 2015

Ok so the issue seems to be that I disabled the RT option in the kOS settings. Here is my local control script:

Code:

set running to true.
set locked to true.

// exit the program
on AG8 { set running to false. }.

// kill rotation
on AG1 {
  set ship:control:neutralize to true.
  lock steering to ship:facing.
  set locked to true.
  preserve.
}.

// pitch up
on AG2 {
  if locked {
    set locked to false.
    unlock steering.
  }
  set ship:control:pitch to -0.25.
  preserve.
}.

// pitch down
on AG3 {
  if locked {
    set locked to false.
    unlock steering.
  }
  set ship:control:pitch to 0.25.
  preserve.
}.

// roll left
on AG4 {
  if locked {
    set locked to false.
    unlock steering.
  }
  set ship:control:roll to -0.25.
  preserve.
}.

// roll right
on AG5 {
  if locked {
    set locked to false.
    unlock steering.
  }
  set ship:control:roll to 0.25.
  preserve.
}.

// yaw left
on AG6 {
  if locked {
    set locked to false.
    unlock steering.
  }
  set ship:control:yaw to -0.25.
  preserve.
}.

// yaw right
on AG7 {
  if locked {
    set locked to false.
    unlock steering.
  }
  set ship:control:yaw to 0.25.
  preserve.
}.

// initialize
clearscreen.
print "Local control enabled".
lock steering to ship:facing.

// program loop
until not running {
  wait 0.01.
}.

// reset controls
unlock steering.
set ship:control:neutralize to true.
print "Local control terminated".

Now, when I have the RT option turned off, if I run the program and it starts immediately but all ship:control commands I send via action group bypassing RemoteTech via AGX take however long the signal delay is to execute even though all other program commands are immediate. If I turn on the RT option then the initial script execution takes however long the signal delay is (which it should, this is proper behavior) and then once the run command has reached the craft and the script is running I have instant ship:control response when I bypass RemoteTech with AGX to trigger the action groups immediately.

So again, RT option off things don't work as they should. RT option on, things all work as expected.

@Dunbaratu
Copy link
Member

not a bug then?

@Dunbaratu Dunbaratu added the invalid Devs do not agree the problem is a problem, or it's a misunderstanding. label Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Devs do not agree the problem is a problem, or it's a misunderstanding.
Projects
None yet
Development

No branches or pull requests

3 participants