New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

our set stuffix casting is too aggressive. #624

Closed

erendrake opened this issue Feb 28, 2015 · 0 comments

Assignees

Labels

Member

erendrake commented Feb 28, 2015

right now, whenever we set a suffix, we are always using the pretty aggressive Convert.ChangeType.

https://github.com/KSP-KOS/KOS/blob/develop/src/kOS.Safe/Encapsulation/Suffixes/SetSuffix.cs#L17

this ignores the fact that many times the type we setting is already correct and a simple cast will do.

erendrake added the enhancement label

erendrake self-assigned this

erendrake closed this as completed in

1a21a8f

erendrake mentioned this issue

Build changelog for v0.17.0 #716

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment