Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking stations used in launches from Kourou #110

Merged
merged 6 commits into from
Jul 14, 2017

Conversation

leudaimon
Copy link

I probably did not use the correct naming convention (nor range), but the location is correct.

I probably did not use the correct naming convention (nor range), but the location is correct.
@PhineasFreak
Copy link

Yea, the station IDs should probably be ESTRACK (even if they are not listed by ESA as such but they support all their launches from Kourou). And they should be yellow (1,1,0,1) since they are tracking stations. The ranges are fine.

@NathanKell
Copy link
Member

PhineasFreak you clearly know this stuff better than I, so go ahead and merge when you feel ready :)

@PhineasFreak
Copy link

@NathanKell I do not have write access to this repository.

Copy link

@eggrobin eggrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add Galliot (about 20 km southwest of the ELAs, 30 km southwest of the ELS, across the river from Kourou)?
https://goo.gl/maps/AeJAmrBe6yM2

STATION
{
Guid = 5105f5a9-d628-41c6-ad4b-21154e8fc999
Name = ESTRACK Ascencion

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo (should be Ascension).

@@ -954,7 +1007,7 @@
// MSFN
STATION
{
Guid = 5106f5a9-d628-41c6-ad4b-21154e8fc100
Guid = 5106f5a9-d629-41c6-ad4b-21154e8fc100

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here?

@eggrobin
Copy link

We definitely want Malindi, https://goo.gl/maps/zCpVyYYuLGt.
Together with Galliot, that would give us the whole network, Galliot→Natal→Ascension→Libreville→Malindi.

@leudaimon
Copy link
Author

@eggrobin I'm on mobile, so I'll take a look at fixing the ascension thing later.
About the guid , iirc I noticed there were two stations with identical IDs, so I just changed one.
About Galliot, isn't it too close to kourou to matter?
Malindi is already in the file, just below the place where I added the other ones

@eggrobin
Copy link

Ah yes, I see Malindi. If we're counting Natal, Ascension, and Librevile as ESTRACK, should Malindi be like that too?
As for Galliot, the thing is the Kourou station in that file has a tiny range, whereas Galliot has the same sort of equipment as the others. If Kourou is in sight of Galliot in-game, perhaps the Kourou station could be removed and we could just keep Galliot, I'm pretty sure Galliot has telemetry from the start IRL: see this document about VA226, section 8, there is no acquisition Galliot.

@PhineasFreak
Copy link

@eggrobin It would probably be better to keep the Kourou station since every RSS launch site is also a tracking station.

@eggrobin
Copy link

A random thought from looking at this file, the comment at the beginning of the file is incorrect, since @NathanKell changed the value from 250 km to 5000 km without updating the comment introduced by @jbengtson.

@eggrobin
Copy link

@PhineasFreak, that makes sense, but then we still need the longer-range station of Galliot (with a known dish, rather than just "is a launch site so 5000 km").

@PhineasFreak
Copy link

@eggrobin Oh, that's OK, more stations are always better! Probably misunderstood your comment...

also fixed other naming details in Ascension and Malindi

The ranges for all these new tracking stations is not accurate according to antenna sizes, more of a guess.
@eggrobin
Copy link

Looks good to me

@NathanKell
Copy link
Member

Merging. Also @PhineasFreak your perms are fixed. :)

@NathanKell NathanKell merged commit ded8a81 into KSP-RO:master Jul 14, 2017
@leudaimon leudaimon deleted the patch-1 branch July 14, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants