-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coatl Aerospace ProbesPlus v0.15RC #1629
Coatl Aerospace ProbesPlus v0.15RC #1629
Conversation
* Fix a possible error with the RCS plume. * Fix the wrong global engine config definition. * Fix the Isp values of the ACS thrusters.
I have been playing with these parts, and have had no issues with any of them. I do not have detailed testing reports, but will continue to report back as I continue. |
@pap1723 Thank you for the review! I do want some feedback since not many RO players use these parts (so balancing may be off). |
@PhineasFreak I will continue to play with them for sure. Do you have IRC or use Discord to chat easier? Anyway, I have started messing around with NSS-OctoSat to generate RO configs and wanted to make sure it wasn't something that you were working on? |
I wanted to start hanging out on the RO IRC but most of the time i am at work and it is difficult to do so (time is available but broken into a ton of small "windows"). No, if you want you are free to go ahead and make configs for it (i am working on the Alcentar's R-7 pack - proves to be somewhat on the difficult side). |
@PhineasFreak IRC is pretty good for the 'small bits of time' state of life. It can be used asynchronously fairly well, where you can ask a question or say something, then look in again later when you have a chance to see if anybody responded, and others can do the same with you. We'd love to see you there, even if you don't talk much (or at all), and just skim the chat log when you have free time, at work, home or otherwise. :) |
PR Looks good to me. @pap1723 or @PhineasFreak , did either of you try landing Venera on Venus? Last time someone tried to land something on Venus, it had trouble surviving the G's, so that part/those parts may need very high G tolerance. The heat shield may also be a bit finicky, since IIRC we've never configured a specifically Venus rated shield before. If either of you have a Venera craft assembled in RO with this config, I'd appreciate it :) |
I haven't tried the venera lander yet, I didn't think it was configured? I
only had one with Surveyor and the satellite parts configured?
…On May 24, 2017 8:01 PM, "stratochief66" ***@***.***> wrote:
PR Looks good to me.
@pap1723 <https://github.com/pap1723> or @PhineasFreak
<https://github.com/phineasfreak> , did either of you try landing Venera
on Venus? Last time someone tried to land something on Venus, it had
trouble surviving the G's, so that part/those parts may need very high G
tolerance. The heat shield may also be a bit finicky, since IIRC we've
never configured a specifically Venus rated shield before.
If either of you have a Venera craft assembled in RO with this config, I'd
appreciate it :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1629 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASjbf3FjHyTGCOCk-Rcng6alqGIlFpsrks5r9NLtgaJpZM4NQiUj>
.
|
@pap1723 all Coatl Aerospace parts are configured for RO (but not RP-0). @stratochief66 sorry about the craft files, i always forget to upload some for testing: LINK REMOVED BY USER Venera is configured properly but some notes:
|
@Starwaster ^^ |
Yep, confirmed that the lander and bus end up with a rotation after separation. Thankfully, without persistent rotation I could 'fix' that by timewarping the rotation away. The chute still ends up heating up really high, and exploding for me. My guess would be that the 'shroud' for the chutes catches heat during entry, passing it to the shield. Not sure how best to handle this. Perhaps having some ablator on the chute to absorb that heat and dissipate it? Chute skin peaked at ~5300K. Even if I hold the chute in reserve until I'm nearly at the ground, it has still overheated (over internal temp) before it reaches the ground. Perhaps the core part needs a radiator or something? IIRC, the actual probe had a cooling system built in, to maximize its life. Also, the KTDU engine doesn't appear to have a plume. Not a deal breaker for this PR, just something I thought you should be aware of. :) A Jettison Shroud button still seems to exist, but doesn't do anything. The decoupler between the bus and landing probe has two Decouple buttons, and if manually triggered in the 'wrong' order, the craft spins into madness. I'd like to move to a release of RO shortly, would it be possible for you to note down/confirm these issues, and work on them later? The PR as is is certainly still a big improvement. |
Edit: So, even if i increase the maximum temperature of the parachute, the lander will be destroyed anyway in an abnormal reentry (sideways or upside down). The lander may need some sort of cooling. I'll see if it is possible to "pre-cool" it before separating it (as it was done IRL).
Seems like it is a stock behavior.
|
Note: the decoupler mass was previously incorrect (too heavy). The new size now reflects better the inert mass value set.
Alright! Some of these challenges may be worth addressing later, but I'm trying to merge up anything big like this so I can make a release. Merging! |
Re: DRE g-forces - yes it still does its own implementation of g-force damage and it's based on the parts crashTolerance. It's something that's been on my mind to revamp for quite awhile. One thing I have in mind to do is adjust the final tolerance by how large/massive the part is. REALLY large parts would be less tolerant for a given value then more compact parts (such as small probes meant for planetary reentry) the code involved is: |
@Starwaster so i guess that we still have to implement custom DRE patches for these parts, right? If so, Tantares has some nice patches for it's Venera. I'll take a look and implement them for the next ProbesPlus update. |
Change log:
General:
Antenna parts:
Command parts:
Control parts:
Electrical parts:
Propulsion parts:
Science parts:
Utility parts:
Notes:
Note 1: There is a missing closing bracket on the base part module that causes MM to fail to patch the part correctly. I have informed raveloda about it and it will be fixed in the next version of ProbesPlus (raveloda/Coatl-Aerospace#56).
Note 2: This PR requires the following global engine configs from the main RO branch:
Note 3: This PR requires #1627 in order for the parachute parts to appear without RealChute installed.
Note 4: Due to the way RealPlume removes the stock plume nodes, the Voyager Payload Module will be missing it's RCS plumes: KSP-RO/RealPlume#24. A fix for that is provided by KSP-RO/RealPlume#29.