Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1kN Thruster has no fuel bars #1681

Closed
Bornholio opened this issue Jun 16, 2017 · 10 comments
Closed

1kN Thruster has no fuel bars #1681

Bornholio opened this issue Jun 16, 2017 · 10 comments

Comments

@Bornholio
Copy link
Contributor

[img]http://i.imgur.com/bwmpZDb.png[/img]
Tested several beginning fuel configurations.

@PhineasFreak
Copy link
Contributor

PhineasFreak commented Jun 16, 2017

IIRC they do not have propellant indicators because they do not actually work as engines but as linear RCS thrusters (uses the same patching conventions from the RO_RCS config file).

@NathanKell
Copy link
Member

They get the propellant and thrust configs from the RCS global configs, but are still engines (this is because ModuleEngines and ModuleRCS take the same PROPELLANT nodes now, and ModuleEngineConfigs is smart enough to know which it's dealing with) but we can totally add DrawGauge = True (or whatever it is) after the engine config. Or, actually, hmm, there should be no harm in putting it in the RCS globals anyway, since the RCS module would just safely ignore it (or use it, which would also be awesome).

@PhineasFreak
Copy link
Contributor

I found an old "issue" (discussion) that i had opened exactly about this feature: #1275

@Bornholio
Copy link
Contributor Author

I'm of the opinion if it is an easy global it would have no harm. Plenty of use of RCS as engine in small sats.
@PhineasFreak if the old issue is same context and completes discussion of the issue feel i can close.
Sorry about not seeing that because I search 1kn in title only I guess.

@PhineasFreak
Copy link
Contributor

No, it is fine! Would you like to create a PR and add this feature? It is relatively easy and painless.

@Bornholio
Copy link
Contributor Author

Bornholio commented Jun 16, 2017

Sure will, I'll also make the modified RO engine config. New branch or add to paps engine config work?

@PhineasFreak
Copy link
Contributor

No limitations apply. Either the mainline RO or the Pap one will do the job. I imagine that the mainline will be faster to merge though.

@Bornholio
Copy link
Contributor Author

looks like the solution if wanted is to add "DrawGauge = True" to the mono-propellant section of RO_RCS_Config.cfg https://www.dropbox.com/s/dxclj4d0288mqwz/RO_RCS_Config.cfg?dl=0
This does not add a gauge to the RCS stage icons of all the RCS units I had in career.
1kn Thruster: http://imgur.com/9sCCLB4
RCS blocks: http://imgur.com/4v4VHHz

@PhineasFreak
Copy link
Contributor

(Un?)fortunately, the ModuleRCS does not support the DrawGauge field so expect that these parts will not be affected by it.

@Bornholio
Copy link
Contributor Author

Commit in and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants