-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1kN Thruster has no fuel bars #1681
Comments
IIRC they do not have propellant indicators because they do not actually work as engines but as linear RCS thrusters (uses the same patching conventions from the RO_RCS config file). |
They get the propellant and thrust configs from the RCS global configs, but are still engines (this is because ModuleEngines and ModuleRCS take the same PROPELLANT nodes now, and ModuleEngineConfigs is smart enough to know which it's dealing with) but we can totally add DrawGauge = True (or whatever it is) after the engine config. Or, actually, hmm, there should be no harm in putting it in the RCS globals anyway, since the RCS module would just safely ignore it (or use it, which would also be awesome). |
I found an old "issue" (discussion) that i had opened exactly about this feature: #1275 |
I'm of the opinion if it is an easy global it would have no harm. Plenty of use of RCS as engine in small sats. |
No, it is fine! Would you like to create a PR and add this feature? It is relatively easy and painless. |
Sure will, I'll also make the modified RO engine config. New branch or add to paps engine config work? |
No limitations apply. Either the mainline RO or the Pap one will do the job. I imagine that the mainline will be faster to merge though. |
looks like the solution if wanted is to add "DrawGauge = True" to the mono-propellant section of RO_RCS_Config.cfg https://www.dropbox.com/s/dxclj4d0288mqwz/RO_RCS_Config.cfg?dl=0 |
(Un?)fortunately, the ModuleRCS does not support the DrawGauge field so expect that these parts will not be affected by it. |
Commit in and merged. |
[img]http://i.imgur.com/bwmpZDb.png[/img]
Tested several beginning fuel configurations.
The text was updated successfully, but these errors were encountered: