Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TacGenericConverter conversionRate field #57

Closed
PhineasFreak opened this issue Nov 5, 2016 · 10 comments
Closed

TacGenericConverter conversionRate field #57

PhineasFreak opened this issue Nov 5, 2016 · 10 comments

Comments

@PhineasFreak
Copy link

One of the nice things of the old TACLS resource converter was that you could scale the imput/output rates by using the "conversionRate" field. Easier than changing all the rates by hand.

Since the current TACLS resource converter already adds custom parameters to the ModuleResourceConverter (like the "requiresAtmo" parameter) would be possible to also support the "conversionRate" parameter?

@JPLRepo
Copy link

JPLRepo commented Nov 5, 2016

Yeah been thinking about that.
TACGenericConverter now just uses the stock ModuleResourceConverter which does not support a conversionRate. BUT, it could if I add it in.
OR, option 2 is use MM variables to do it.

@JPLRepo
Copy link

JPLRepo commented Nov 5, 2016

Added conversionRate field (float value accepted so can have decimal values) to TACGenericConverter. Optional PartModule field. Defaults to value of 1. Value must be > 0 otherwise is set to 1.
If supplied and not equal to 1 will multiply all inputs, outputs, requirements node resources by this value.

@PhineasFreak
Copy link
Author

Wow, that was quick! I really appreciate it that you took the time to add it!

@JPLRepo
Copy link

JPLRepo commented Nov 6, 2016

No probs. should have done to begin with when I converted it over. Knew it! I haven't tested it yet. I'll do a dev build tomorrow and post here so you can test it out.

@PhineasFreak
Copy link
Author

OK. And again, thank you!

@JPLRepo
Copy link

JPLRepo commented Nov 7, 2016

Here is the Dev build link:
https://github.com/KSP-RO/TacLifeSupport/releases/tag/v0.12.7dev

@PhineasFreak
Copy link
Author

Tested the latest release, everything is in order!

@JPLRepo
Copy link

JPLRepo commented Nov 10, 2016

Thanks mate. Good to hear. got a bit of noise of other bugs being reported. so will need to look at those before I do the next version release.

@PhineasFreak
Copy link
Author

If you want go ahead and close this one.

@JPLRepo
Copy link

JPLRepo commented Nov 15, 2016

Yeah I will once it's released. I have to create a milestones to link it to first. Call me pedantic. I like audit trails. Plus I gotta create the change log using a script. All good. It's marked as ready to implement.

@JPLRepo JPLRepo closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants