New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TacGenericConverter conversionRate field #57
Comments
Yeah been thinking about that. |
Added conversionRate field (float value accepted so can have decimal values) to TACGenericConverter. Optional PartModule field. Defaults to value of 1. Value must be > 0 otherwise is set to 1. |
Wow, that was quick! I really appreciate it that you took the time to add it! |
No probs. should have done to begin with when I converted it over. Knew it! I haven't tested it yet. I'll do a dev build tomorrow and post here so you can test it out. |
OK. And again, thank you! |
Here is the Dev build link: |
Tested the latest release, everything is in order! |
Thanks mate. Good to hear. got a bit of noise of other bugs being reported. so will need to look at those before I do the next version release. |
If you want go ahead and close this one. |
Yeah I will once it's released. I have to create a milestones to link it to first. Call me pedantic. I like audit trails. Plus I gotta create the change log using a script. All good. It's marked as ready to implement. |
One of the nice things of the old TACLS resource converter was that you could scale the imput/output rates by using the "conversionRate" field. Easier than changing all the rates by hand.
Since the current TACLS resource converter already adds custom parameters to the ModuleResourceConverter (like the "requiresAtmo" parameter) would be possible to also support the "conversionRate" parameter?
The text was updated successfully, but these errors were encountered: