Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github integration #33

Open
Shuudoushi opened this issue Feb 16, 2016 · 11 comments
Open

Github integration #33

Shuudoushi opened this issue Feb 16, 2016 · 11 comments

Comments

@Shuudoushi
Copy link

Fixing how this is put, that is all.

Adding github integration on the level of an author (who has linked the accounts) will only have to post a release to github, and the release be pulled to spacedock automatically as an update to the mod in question. Changelog and the like can be automatically filled out by pulled from changelog.md files as well. On page issue reporting (i.g. not having to go to the github page to post or review issues) can also be supported, though I don't recall how this is handled.

@ghost ghost added the Type: Improvement label Feb 16, 2016
@ghost ghost added this to the SpaceDock 1.0 "Phoenix" milestone Feb 16, 2016
@jkoritzinsky
Copy link

To make this work the best, it should integrate as a webhook that gets notified every time a release is released.

@StollD StollD closed this as completed Mar 3, 2016
@V1TA5 V1TA5 reopened this Mar 3, 2016
@Shuudoushi Shuudoushi changed the title Github repo linking Github intergration Mar 3, 2016
@politas
Copy link

politas commented Mar 7, 2016

Only issue I can see is that Github doesn't have metadata for which KSP version is supported, so mod authors would need to update that on Spacedock afterwards.

@jkoritzinsky
Copy link

Pull data from a .ckan, .netkan, or .version file if it is present in the repository (possible to get via GH API) maybe?

@politas
Copy link

politas commented Mar 8, 2016

Where possible, sure. Mainly need to make sure that mod authors setting up the link are aware of the limitations/requirements/possibilities.

@GenPage
Copy link

GenPage commented Mar 9, 2016

@politas That is find, part of the GitHub integration would be to not publish the mod, so that the modder will have to publish it manually first thus updating the mod on SpaceDock afterwards.

@jkoritzinsky I'm also not opposed to a version file if present. We'll need to flush the workflow out more

@Shuudoushi
Copy link
Author

Version info could just be pulled from the tag that is created while drafting a release on github, as most modders use this tag to denote version number anyway.

@politas
Copy link

politas commented Mar 10, 2016

Mod version number, yeah, but not supported KSP version.

@Shuudoushi
Copy link
Author

@politas That can be set during first time setup, i.g. where you create the mod page on spacedock itself.

@politas
Copy link

politas commented Mar 10, 2016

...Until a new version of KSP is released.

@inigmatus
Copy link

...new version nearly released. :)

@HebaruSan HebaruSan changed the title Github intergration Github integration Jun 9, 2020
@HebaruSan
Copy link
Contributor

In case any modders are interested, Nertea has done this on the GitHub side via the API:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants