Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CONFIG_DEBUG_LIST better and default=y #10

Closed
kees opened this issue Sep 26, 2019 · 9 comments
Closed

Rename CONFIG_DEBUG_LIST better and default=y #10

kees opened this issue Sep 26, 2019 · 9 comments
Assignees
Labels
[Linux] v6.6 Released in Linux kernel v6.6 robustness Improve kernel code robustness

Comments

@kees
Copy link

kees commented Sep 26, 2019

CONFIG_DEBUG_LIST has been enabled in distros for a long time. It should be switched to default=y and likely named something better, like CONFIG_HARDENED_LIST.

@kees
Copy link
Author

kees commented Oct 24, 2019

Evidence that this has real-world defensive impact:
https://bugs.chromium.org/p/project-zero/issues/detail?id=1942

@willdeacon
Copy link
Collaborator

I've started looking at this, so feel free to assign this to me if you like.

@willdeacon
Copy link
Collaborator

RFC: https://lore.kernel.org/lkml/20200324153643.15527-1-will@kernel.org/T/#t

Will definitely need more work, but it's a start. I haven't done the default=y because I've added a bunch of extra checks and we'd probably need performance data to justify enabling them by default.

@kees kees added the [PATCH] Exists A patch exists to address the issue label Apr 7, 2021
@kees
Copy link
Author

kees commented Apr 7, 2021

What's the status of this series? It looks like it was pretty close to landing from the RFC.

@willdeacon
Copy link
Collaborator

I got stuck because some of the code is shared between the synchronized and RCU/lockless paths:

https://lore.kernel.org/r/20200424173932.GK21141@willie-the-truck

But I agree that I should try to dust this back off and see if I can figure it out again.

@kees
Copy link
Author

kees commented Sep 1, 2021

Ping -- what's left for this series to land?

@kees
Copy link
Author

kees commented Apr 7, 2022

Who would be best to help solve the RCU/lockless paths?

@kees kees added the robustness Improve kernel code robustness label Apr 7, 2022
@melver
Copy link

melver commented Aug 9, 2023

I found CONFIG_DEBUG_LIST to have measurable performance impact in some cases. FTR, attempts to optimize it: https://lkml.kernel.org/r/20230808102049.465864-1-elver@google.com

@kees kees added [Linux] v6.6 Released in Linux kernel v6.6 and removed [PATCH] Exists A patch exists to address the issue labels Feb 7, 2024
@kees
Copy link
Author

kees commented Feb 7, 2024

CONFIG_LIST_HARDENED has been landed in commit aebc7b0.

@kees kees closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Linux] v6.6 Released in Linux kernel v6.6 robustness Improve kernel code robustness
Projects
None yet
Development

No branches or pull requests

3 participants