Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguishing Text vs Math Fonts #1112

Closed
ry-randall opened this issue Jan 28, 2018 · 0 comments
Closed

Distinguishing Text vs Math Fonts #1112

ry-randall opened this issue Jan 28, 2018 · 0 comments
Assignees
@ry-randall
Labels
code cleanup

Comments

@ry-randall
Copy link
Member

ry-randall commented Jan 28, 2018 •
edited

One difference with math vs text font commands, is text commands change one aspect of the font (weight, shape, or family). Math commands change all aspects of the font (weight, shape, and family). Currently options.withFontFamily is being used for math fonts as well a text families.

We should leverage options.withFont() for math, and options.withFontFamily/Shape/Weight for text.

Alternatively, a simpler solution could be to rename withFontFamily or provide a descriptive comment explaining it's multiple uses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ry-randall ry-randall

Labels
code cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinbarabash @ry-randall