Cleanup makeOrd Function

[ry-randall]

Currently the makeOrd function does too much. The purpose of this is to clean it up and make it more readable.

From: #1111

[kevinbarabash]

@rrandallcainc this probably doesn't fit within the scope of what you were thinking of but someday it would be nice if we had an IR were the ord nodes contained exactly what font each character should be rendered as.

[edemaine]

@kevinbarabash Perhaps a function that maps the various font properties from #1111 into that actual font would be just as good, and perhaps the main role of makeOrd? I've forgotten the details, but every time I look at the font choice code (and e.g. mathDefault) I feel like they are very confusing, possibly wrong, and could be improved.

[kevinbarabash]

I think if we split it up into two mappings that may simplify things. Those two mappings might be:

• current options, character => family, weight, style
• family, weight, style, character => actually CSS class for that font

[edemaine]

Mapping to CSS classes may also require knowing the parent CSS classes, to avoid repetition. Or maybe that's a third step, checking how your desired CSS class differs from the parent and thus what needs specifying.

[ry-randall]

@edemaine By a function that maps the various properties, were you referring to something like this? https://github.com/Khan/KaTeX/blob/master/src/buildCommon.js#L601

@kevinbarabash I'm a little fuzzy on what you mean by "IR were the ord nodes contained exactly what font each character should be rendered as.". Are you referring to something like: render "hello" as SansSerif-Bold?

[ry-randall]

It's been a little while since opening this. I'll start taking a look at this.

[kevinbarabash]

@kevinbarabash I'm a little fuzzy on what you mean by "IR were the ord nodes contained exactly what font each character should be rendered as.". Are you referring to something like: render "hello" as SansSerif-Bold?

I was thinking that each character within the IR would have a specific font style.