New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fonts): correct width of \cong glyph, fix \boldsymbol{\cong} #3206
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3206 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 88 88
Lines 6557 6557
Branches 1513 1513
=======================================
Hits 6134 6134
Misses 393 393
Partials 30 30 Continue to review full report at Codecov.
|
Hmm, there seems to be something wrong with the fonts now: the space has gotten bigger: @ylemkimon Any ideas? I thought the fonts were maybe not updated, but I see you just updated them. Update: I think the SetRBearing needs to be a bunch smaller than the width... hmm... |
I wonder we should fix the date of fonts to a specific date in the past. Currently, a change in a font requires updating all the fonts. (done in #3370) |
I found a fix. Patch incoming. |
@ylemkimon I updated this to use the new font versioning. Would you be able to review it (again)? Here's a demo from the Netlify build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this and sorry for the delayed review.
🎉 This PR is included in version 0.13.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR is currently based on #2866 for build purposes. I'll rebase once #2866 is merged.Rebased.What is the previous behavior before this PR?
\cong
had the default advanceWidth of 1000What is the new behavior after this PR?
\cong
has the correct advanceWidth, matching=
that it's based on (and many other binary operators).Fixes #2199