Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): __defineFunction API exposing internal defineFunction #3805

Merged
merged 2 commits into from Apr 17, 2023
Merged

feat(api): __defineFunction API exposing internal defineFunction #3805

merged 2 commits into from Apr 17, 2023

Conversation

edemaine
Copy link
Member

KaTeX libraries should be allowed to define functions.

What is the previous behavior before this PR?

We offered __defineMacro and __defineSymbol, but no __defineFunction.

What is the new behavior after this PR?

Expose defineFunction via __defineFunction. Like __defineMacro and __defineSymbol, the API isn't documented.

Fixes #3756.

@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited

Codecov Report

Merging #3805 (08de1f9) into main (8186945) will not change coverage.
The diff coverage is n/a.

❗ Current head 08de1f9 differs from pull request most recent head a6c5545. Consider uploading reports for the commit a6c5545 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3805   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files          91       91           
  Lines        6770     6770           
  Branches     1574     1574           
=======================================
  Hits         6295     6295           
  Misses        437      437           
  Partials       38       38

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8186945...a6c5545. Read the comment docs.

@edemaine edemaine requested a review from ronkok April 11, 2023 16:24
ronkok
ronkok approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@ronkok ronkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this feature, I suspect that the number of potential users is one.

In which case, yay!, go for it.

If you dream up any particularly useful functions, let me know about them. Maybe I'll add them to Temml.

@edemaine edemaine enabled auto-merge (squash) April 17, 2023 17:46
@edemaine edemaine merged commit c7b1f84 into main Apr 17, 2023
8 checks passed
@edemaine edemaine deleted the api branch April 17, 2023 17:49
KaTeX-bot added a commit that referenced this pull request Apr 17, 2023
@KaTeX-bot
chore(release): 0.16.5 [ci skip]
bd502a6 
## [0.16.5](v0.16.4...v0.16.5) (2023-04-17)

### Features

* __defineFunction API exposing internal defineFunction ([#3805](#3805)) ([c7b1f84](c7b1f84)), closes [#3756](#3756)
@KaTeX-bot
Copy link
Member

🎉 This PR is included in version 0.16.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronkok ronkok ronkok approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expose defineFunction
3 participants
@edemaine @KaTeX-bot @ronkok