Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.7.0 no dist folder #613

Closed
yama6a opened this issue Jan 9, 2017 · 9 comments
Closed

0.7.0 no dist folder #613

yama6a opened this issue Jan 9, 2017 · 9 comments

Comments

@yama6a
Copy link

yama6a commented Jan 9, 2017

When pulling in katex 0.7.0 via bower, I don't get a dist-folder but only a bower.json file in the bower_components/katex/ folder. Even when I remove it and pull it in as a sub dependency of angular-katex it is the same result. Why could that be?

@gagern
Copy link
Collaborator

gagern commented Jan 9, 2017

OK, this has been reported before, in #240 which got closed as a duplicate of #114. That one was aimed to address both bower and npm, and got fixed with #436 closing the npm half of the issue. The bower problem apparently remains open. @spicyj do you agree with this analysis?

Bower 1.8.0 reports this for me:

bower install katex
bower not-cached    https://github.com/Khan/KaTeX.git#*
bower resolve       https://github.com/Khan/KaTeX.git#*
bower download      https://github.com/Khan/KaTeX/archive/v0.7.0.tar.gz
bower extract       katex#* archive.tar.gz
bower invalid-meta  for:…/bower.json
bower invalid-meta  The "name" is recommended to be lowercase, can contain digits, dots, dashes
bower invalid-meta  The "main" field cannot contain minified files
bower invalid-meta  The "main" field cannot contain minified files
bower resolved      https://github.com/Khan/KaTeX.git#0.7.0
bower install       KaTeX#0.7.0

KaTeX#0.7.0 bower_components/KaTeX

That tarball is a source archive, so it doesn't contain dist, nor should it. The error messages are something else but shouldn't be too severe.

@yama6a
Copy link
Author

yama6a commented Jan 9, 2017

Well it appears as if pulling in v0.6.0 with bower works, only from v0.7.0 ist is a problem, but since we need the support for umlaut characters, that is not an option...

@zeitgeist87
Copy link

I have the exact same issue. Bower 1.8.0 reports this:

node_modules/bower/bin/bower install -V
bower katex#*               not-cached https://github.com/Khan/KaTeX.git#*
bower katex#*                  resolve https://github.com/Khan/KaTeX.git#*
bower katex#*                 download https://github.com/Khan/KaTeX/archive/v0.7.0.tar.gz
bower katex#*                  extract archive.tar.gz
bower katex#*             invalid-meta for:/tmp/andreas/bower/f1a02a1ae7fa47b237f875a1e98ba21e-7732-wZegpf/bower.json
bower katex#*             invalid-meta The "name" is recommended to be lowercase, can contain digits, dots, dashes
bower katex#*             invalid-meta The "main" field cannot contain minified files
bower katex#*             invalid-meta The "main" field cannot contain minified files
bower katex#*                 resolved https://github.com/Khan/KaTeX.git#0.7.0
bower katex#*                  install katex#0.7.0

katex#0.7.0 bower_components/katex

After that the directory ./bower_components/katex/ contains only bower.json.

@yama6a
Copy link
Author

yama6a commented Jan 10, 2017

Exactly the same for me.

When I compare the two tar balls of 0.6.0 and 0.7.0, I can see that v0.6.0 does have a dist folder in it, where as the 0.7.0 doesn't...

https://github.com/Khan/KaTeX/archive/v0.7.0.tar.gz
vs.
https://github.com/Khan/KaTeX/archive/v0.6.0.tar.gz

@gagern
Copy link
Collaborator

gagern commented Jan 10, 2017

#114 (comment) has an analysis of what went wrong. Main reason is that I didn't consider bower in #546, where I added dist to .gitignore to avoid warnings about that directory during development. #615 aims to fix this, and personally I'd suggest creating a 0.7.1 release to add bower support.

@yama6a
Copy link
Author

yama6a commented Jan 11, 2017

@gagern Thanks a lot for you lightspeed rection. Much appreciated!

@gagern
Copy link
Collaborator

gagern commented Jan 22, 2017

I released v0.7.1 which has a dist folder again. I have been able to use it with bower.

@gagern gagern closed this as completed Jan 22, 2017
@zeitgeist87
Copy link

I can confirm that v0.7.1 solves the problem. Thanks!

@yama6a
Copy link
Author

yama6a commented Mar 9, 2017

Yup, all good now. Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants