Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed license to BSD-3-Clause; bump to 0.0.7 #21

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Changed license to BSD-3-Clause; bump to 0.0.7 #21

merged 2 commits into from
Sep 18, 2020

Conversation

mrJeong
Copy link
Contributor

@mrJeong mrJeong commented Sep 15, 2020

No description provided.

sublee
sublee suggested changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@sublee sublee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. I agree that you've changed everywhere to change the license. I commented on minor notation issues. Please review them before merging.

LICENSE Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.ko.md Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@sublee sublee added the enhancement New feature or request label Sep 15, 2020
@chiheonk @sublee
Apply suggestions from code review
7e39b29 
Co-authored-by: Heungsub Lee <heungsub.lee@kakaobrain.com>
sublee
sublee approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@sublee sublee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chiheonk chiheonk merged commit b69908d into master Sep 18, 2020
@chiheonk chiheonk deleted the bsd branch September 18, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sublee sublee sublee approved these changes

@chiheonk chiheonk chiheonk approved these changes

Assignees

@mrJeong mrJeong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrJeong @sublee @chiheonk