-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added builder functions #105
Conversation
request := message.NewRequest(method.INVITE, "4321@127.0.0.1", "1234@127.0.0.1") //Args: METHOD TO HEADER FROM HEADER | ||
} | ||
|
||
func (c *Client) Start(host string, port int) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.Start should have comment or be unexported
|
||
} | ||
|
||
func (c *Client) SendInvite() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.SendInvite should have comment or be unexported
|
||
} | ||
|
||
func (c *Client) HandleResponses(event interfaces.SipEventObject) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.HandleResponses should have comment or be unexported
stack *kalbi.SipStack | ||
} | ||
|
||
func (c *Client) HandleRequests(event interfaces.SipEventObject) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.HandleRequests should have comment or be unexported
"github.com/KalbiProject/Kalbi/sip/status" | ||
) | ||
|
||
type Client struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type Client should have comment or be unexported
toUser, toDomain := toArr[0], toArr[1] | ||
fromUser, fromDomain := fromArr[0], fromArr[1] | ||
|
||
//NewRequest creates new SIP request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment on exported function NewResponse should be of the form "NewResponse ..."
request := message.NewRequest(method.INVITE, "4321@127.0.0.1", "1234@127.0.0.1") //Args: METHOD TO HEADER FROM HEADER | ||
} | ||
|
||
func (c *Client) Start(host string, port int) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.Start should have comment or be unexported
|
||
} | ||
|
||
func (c *Client) SendInvite() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.SendInvite should have comment or be unexported
|
||
} | ||
|
||
func (c *Client) HandleResponses(event interfaces.SipEventObject) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.HandleResponses should have comment or be unexported
stack *kalbi.SipStack | ||
} | ||
|
||
func (c *Client) HandleRequests(event interfaces.SipEventObject) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.HandleRequests should have comment or be unexported
"github.com/KalbiProject/Kalbi/sip/status" | ||
) | ||
|
||
type Client struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type Client should have comment or be unexported
No description provided.