Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create golangci.yml #84

Merged
merged 20 commits into from
Oct 17, 2020
Merged

Create golangci.yml #84

merged 20 commits into from
Oct 17, 2020

Conversation

DeWarner
Copy link
Collaborator

No description provided.

@DeWarner DeWarner marked this pull request as draft October 13, 2020 19:15
@DeWarner DeWarner marked this pull request as ready for review October 13, 2020 19:19

func (p *Proxy) FindUser(key string) {
func (p *Proxy) HandleResponse(response transaction.Transaction) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported method Proxy.HandleResponse should have comment or be unexported


func (p *Proxy) FindUser(key string) {
func (p *Proxy) HandleResponse(response transaction.Transaction) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported method Proxy.HandleResponse should have comment or be unexported

func (p *Proxy) HandleResponse(response transaction.Transaction) {
fmt.Println(string(response.GetOrigin().Req.Src))

func (p *Proxy) AddToRegister(key string, contact string) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported method Proxy.AddToRegister should have comment or be unexported

@DeWarner DeWarner merged commit e2e5016 into master Oct 17, 2020
@DeWarner DeWarner deleted the golangci-workflow branch October 17, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant