-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign #87
Conversation
@@ -55,6 +55,11 @@ func (ed *SipStack) CreateResponseChannel() chan transaction.Transaction { | |||
return Channel | |||
} | |||
|
|||
func (ed *SipStack) SetSipListener(listener transaction.SipListener){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method SipStack.SetSipListener should have comment or be unexported
|
||
|
||
|
||
type SipListener interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type SipListener should have comment or be unexported
@@ -187,3 +188,8 @@ func (tm *TransactionManager) NewServerTransaction(msg *message.SipMsg) *ServerT | |||
return tx | |||
|
|||
} | |||
|
|||
|
|||
func (tm *TransactionManager) SetSipListener(listener SipListener) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method TransactionManager.SetSipListener should have comment or be unexported
@@ -55,6 +55,11 @@ func (ed *SipStack) CreateResponseChannel() chan transaction.Transaction { | |||
return Channel | |||
} | |||
|
|||
func (ed *SipStack) SetSipListener(listener transaction.SipListener){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method SipStack.SetSipListener should have comment or be unexported
No description provided.